Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add BitVec.ofFn and lemmas #1078
base: main
Are you sure you want to change the base?
feat: add BitVec.ofFn and lemmas #1078
Changes from 1 commit
b630163
9b358f6
f7ae994
1f26464
d8bd13d
7a8b3e2
4613b2e
66a7724
4b995c9
9ac228f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New functions creating BitVecs should have simp lemmas for
toNat
,toFin
, and ideally alsotoInt
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't that need the
Nat
/Fin
/Int
functions to already exist in some way? I would probably just implement those using the BitVec version.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added
Nat.ofBits
andFin.ofBits
, little endian only since that's the wayNat.testBit
works. I will try to think about what the rightInt
version should be.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
Int.ofBits
would require upstreamingInt.testBit
from Mathlib. Let me know if you think that's a good idea and I will get it done.