feat: add BitVec.ofFn and lemmas #1078
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgdorais
added
the
awaiting-review
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 23, 2024
|
Mathlib CI status (docs):
|
kim-em
reviewed
Jan 5, 2025
kim-em
reviewed
Jan 5, 2025
Batteries/Data/BitVec.lean
Outdated
| Fin.foldr n (fun i v => v.shiftConcat (f i)) 0 | ||
|
|
||
| /-- `ofFn f` returns the `BitVec n` whose `i`th bit is `f i` -/ | ||
| abbrev ofFn (f : Fin n → Bool) : BitVec n := ofFnAux n f |
There was a problem hiding this comment.
New functions creating BitVecs should have simp lemmas for toNat, toFin, and ideally also toInt.
There was a problem hiding this comment.
Doesn't that need the Nat/Fin/Int functions to already exist in some way? I would probably just implement those using the BitVec version.
There was a problem hiding this comment.
I added Nat.ofBits and Fin.ofBits, little endian only since that's the way Nat.testBit works. I will try to think about what the right Int version should be.
There was a problem hiding this comment.
Adding Int.ofBits would require upstreaming Int.testBit from Mathlib. Let me know if you think that's a good idea and I will get it done.
kim-em
reviewed
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.