Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering chat with Readable Colors #1047

Closed
2 tasks done
Steve-Soeiro opened this issue May 1, 2024 · 6 comments · Fixed by #1072
Closed
2 tasks done

Rendering chat with Readable Colors #1047

Steve-Soeiro opened this issue May 1, 2024 · 6 comments · Fixed by #1072
Labels
enhancement New feature or request

Comments

@Steve-Soeiro
Copy link

Checklist

Write your feature request here

In Chat Settings -> Chat Appearance, there is an option "Readable Colors" which makes all the names with dark colors more light, I think, which makes reading chat much easier and more enjoyable.

Is it possible to add that option, like a checkmark, to be able to render chat with "Readable Colors"?

@Steve-Soeiro Steve-Soeiro added the enhancement New feature or request label May 1, 2024
@ScrubN
Copy link
Collaborator

ScrubN commented May 9, 2024

It looks like we already have this implemented, but only when users don't have custom colors. I'll look into making it a checkbox instead.

@Steve-Soeiro
Copy link
Author

Can you force it on every user, like Twitch?

@ScrubN
Copy link
Collaborator

ScrubN commented May 9, 2024

That is the idea

@ScrubN
Copy link
Collaborator

ScrubN commented May 19, 2024

It looks like we already have this implemented, but only when users don't have custom colors. I'll look into making it a checkbox instead.

I misread the code when I posted this comment. Readable colors were always being applied, but the correction was very weak.

@ScrubN
Copy link
Collaborator

ScrubN commented May 23, 2024

Please review the screenshots in #1072 and tell me if the adjustment is good enough or if I need to increase it even more.

@Steve-Soeiro
Copy link
Author

The dark blue is better but could be a little lighter. The others look good.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants