Explicitly stop taskbar flashing after 4 seconds

lay295 · Dec 1, 2023 · a2280bb · a2280bb
1 parent cf35e4c
commit a2280bb
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 15 deletions.
diff --git a/TwitchDownloaderWPF/MainWindow.xaml.cs b/TwitchDownloaderWPF/MainWindow.xaml.cs
@@ -4,6 +4,7 @@
 using System.IO;
 using System.Net;
 using System.Runtime.InteropServices;
+using System.Threading;
 using System.Windows;
 using System.Windows.Interop;
 using TwitchDownloaderWPF.Properties;
@@ -103,20 +104,7 @@ private async void Window_Loaded(object sender, RoutedEventArgs e)
 
             // Flash the window taskbar icon if it is not in the foreground. This is to mitigate a problem where
             // it will sometimes start behind other windows, usually (but not always) due to the user's actions.
-            var currentWindow = new WindowInteropHelper(this).Handle;
-            var foregroundWindow = NativeFunctions.GetForegroundWindow();
-            if (currentWindow != foregroundWindow)
-            {
-                var flashInfo = new NativeFunctions.FlashWInfo
-                {
-                    StructSize = (uint)Marshal.SizeOf<NativeFunctions.FlashWInfo>(),
-                    WindowHandle = new WindowInteropHelper(this).Handle,
-                    Flags = NativeFunctions.FlashWInfo.FLASHW_TRAY,
-                    FlashCount = uint.MaxValue,
-                    Timeout = 0
-                };
-                NativeFunctions.FlashWindowEx(flashInfo);
-            }
+            FlashWindowIfNotForeground(TimeSpan.FromSeconds(4));
 
             AutoUpdater.InstalledVersion = currentVersion;
 #if !DEBUG
@@ -129,6 +117,40 @@ private async void Window_Loaded(object sender, RoutedEventArgs e)
 #endif
         }
 
+        private void FlashWindowIfNotForeground(TimeSpan flashDuration)
+        {
+            var currentWindow = new WindowInteropHelper(this).Handle;
+            var foregroundWindow = NativeFunctions.GetForegroundWindow();
+            if (currentWindow == foregroundWindow)
+                return;
+
+            var flashWInfo = new NativeFunctions.FlashWInfo
+            {
+                StructSize = (uint)Marshal.SizeOf<NativeFunctions.FlashWInfo>(),
+                WindowHandle = currentWindow,
+                Flags = NativeFunctions.FlashWInfo.FLASHW_TRAY,
+                FlashCount = uint.MaxValue,
+                Timeout = 0
+            };
+            _ = NativeFunctions.FlashWindowEx(flashWInfo);
+
+            _ = new Timer(static state =>
+            {
+                if (state is not IntPtr windowHandle)
+                    return;
+
+                var flashWInfo = new NativeFunctions.FlashWInfo
+                {
+                    StructSize = (uint)Marshal.SizeOf<NativeFunctions.FlashWInfo>(),
+                    WindowHandle = windowHandle,
+                    Flags = NativeFunctions.FlashWInfo.FLASHW_STOP,
+                    FlashCount = 0,
+                    Timeout = 0
+                };
+                _ = NativeFunctions.FlashWindowEx(flashWInfo);
+            }, currentWindow, flashDuration, Timeout.InfiniteTimeSpan);
+        }
+
         private class FfmpegDownloadProgress : IProgress<ProgressInfo>
         {
             private int _lastPercent = -1;

diff --git a/TwitchDownloaderWPF/Services/NativeFunctions.cs b/TwitchDownloaderWPF/Services/NativeFunctions.cs
@@ -14,6 +14,7 @@ public static unsafe class NativeFunctions
         public static extern IntPtr GetForegroundWindow();
 
         [DllImport("user32.dll", EntryPoint = "FlashWindowEx", PreserveSig = true)]
+        [return: MarshalAs(UnmanagedType.Bool)]
         public static extern bool FlashWindowEx(FlashWInfo info);
 
         // https://learn.microsoft.com/en-us/windows/win32/api/winuser/ns-winuser-flashwinfo

diff --git a/TwitchDownloaderWPF/Services/ThemeService.cs b/TwitchDownloaderWPF/Services/ThemeService.cs
@@ -116,7 +116,8 @@ public void SetTitleBarTheme(WindowCollection windows)
             {
                 SizeToContent = SizeToContent.WidthAndHeight,
                 Top = int.MinValue + 1,
-                WindowStyle = WindowStyle.None
+                WindowStyle = WindowStyle.None,
+                ShowInTaskbar = false
             };
             wnd.Show();
             wnd.Close();