Skip to content

Commit

Permalink
Add Save/Cancel/Reset buttons to settings window (#902)
Browse files Browse the repository at this point in the history
* Regenerate WPF settings files with VS2022

* Add reset, save, and cancel buttons to settings window

* Use translations

* Use translations for buttons

* Update margin

* Minor nitpicks

* Fix typo

* Update some default settings
  • Loading branch information
ScrubN authored Nov 29, 2023
1 parent 869068b commit 109cbae
Show file tree
Hide file tree
Showing 14 changed files with 409 additions and 83 deletions.
25 changes: 3 additions & 22 deletions TwitchDownloaderWPF/App.config
Original file line number Diff line number Diff line change
Expand Up @@ -5,32 +5,13 @@
<section name="TwitchDownloaderWPF.Properties.Settings" type="System.Configuration.ClientSettingsSection, System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" allowExeDefinition="MachineToLocalUser" requirePermission="false" />
</sectionGroup>
</configSections>
<startup>
<supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.7.2" />
</startup>
<runtime>
<assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
<dependentAssembly>
<assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-12.0.0.0" newVersion="12.0.0.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="System.Runtime.CompilerServices.Unsafe" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-5.0.0.0" newVersion="5.0.0.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="System.Buffers" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-4.0.3.0" newVersion="4.0.3.0" />
</dependentAssembly>
</assemblyBinding>
</runtime>
<userSettings>
<TwitchDownloaderWPF.Properties.Settings>
<setting name="VodDownloadThreads" serializeAs="String">
<value>4</value>
</setting>
<setting name="Font" serializeAs="String">
<value>Arial</value>
<value>Inter Embedded</value>
</setting>
<setting name="FontSize" serializeAs="String">
<value>24</value>
Expand All @@ -48,7 +29,7 @@
<value>700</value>
</setting>
<setting name="UpdateTime" serializeAs="String">
<value>0.5</value>
<value>0.2</value>
</setting>
<setting name="FFZEmotes" serializeAs="String">
<value>True</value>
Expand Down Expand Up @@ -216,7 +197,7 @@
<value>1</value>
</setting>
<setting name="DisperseCommentOffsets" serializeAs="String">
<value>False</value>
<value>True</value>
</setting>
<setting name="GuiCulture" serializeAs="String">
<value>en-US</value>
Expand Down
6 changes: 3 additions & 3 deletions TwitchDownloaderWPF/Properties/Settings.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions TwitchDownloaderWPF/Properties/Settings.settings
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<Value Profile="(Default)">4</Value>
</Setting>
<Setting Name="Font" Type="System.String" Scope="User">
<Value Profile="(Default)">Arial</Value>
<Value Profile="(Default)">Inter Embedded</Value>
</Setting>
<Setting Name="FontSize" Type="System.Single" Scope="User">
<Value Profile="(Default)">24</Value>
Expand All @@ -24,7 +24,7 @@
<Value Profile="(Default)">700</Value>
</Setting>
<Setting Name="UpdateTime" Type="System.Double" Scope="User">
<Value Profile="(Default)">0.5</Value>
<Value Profile="(Default)">0.1</Value>
</Setting>
<Setting Name="FFZEmotes" Type="System.Boolean" Scope="User">
<Value Profile="(Default)">True</Value>
Expand Down Expand Up @@ -192,7 +192,7 @@
<Value Profile="(Default)">1</Value>
</Setting>
<Setting Name="DisperseCommentOffsets" Type="System.Boolean" Scope="User">
<Value Profile="(Default)">False</Value>
<Value Profile="(Default)">True</Value>
</Setting>
<Setting Name="GuiCulture" Type="System.String" Scope="User">
<Value Profile="(Default)">en-US</Value>
Expand Down
63 changes: 63 additions & 0 deletions TwitchDownloaderWPF/Translations/Strings.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions TwitchDownloaderWPF/Translations/Strings.es.resx
Original file line number Diff line number Diff line change
Expand Up @@ -787,4 +787,25 @@
<data name="OpenVideoInBrowser" xml:space="preserve">
<value>Open in browser</value>
</data>
<data name="ResetSettingsConfirmationMessage" xml:space="preserve">
<value>Are you sure you want to reset all settings to their default values?</value>
</data>
<data name="ResetSettingsConfirmation" xml:space="preserve">
<value>Restore Settings Confirmation</value>
</data>
<data name="TheApplicationMustBeRestartedMessage" xml:space="preserve">
<value>The application must be restarted for changes to take effect.</value>
</data>
<data name="RestartTheApplication" xml:space="preserve">
<value>Please restart {0}</value><comment>{0} is the name of the application.</comment>
</data>
<data name="ButtonRestoreDefaultSettings" xml:space="preserve">
<value>Restore Defaults</value>
</data>
<data name="ButtonSaveSettings" xml:space="preserve">
<value>Save</value>
</data>
<data name="ButtonCancelSettingsChanges" xml:space="preserve">
<value>Cancel</value>
</data>
</root>
21 changes: 21 additions & 0 deletions TwitchDownloaderWPF/Translations/Strings.fr.resx
Original file line number Diff line number Diff line change
Expand Up @@ -786,4 +786,25 @@
<data name="OpenVideoInBrowser" xml:space="preserve">
<value>Ouvrir dans un navigateur web</value>
</data>
<data name="ResetSettingsConfirmationMessage" xml:space="preserve">
<value>Are you sure you want to reset all settings to their default values?</value>
</data>
<data name="ResetSettingsConfirmation" xml:space="preserve">
<value>Restore Settings Confirmation</value>
</data>
<data name="TheApplicationMustBeRestartedMessage" xml:space="preserve">
<value>The application must be restarted for changes to take effect.</value>
</data>
<data name="RestartTheApplication" xml:space="preserve">
<value>Please restart {0}</value><comment>{0} is the name of the application.</comment>
</data>
<data name="ButtonRestoreDefaultSettings" xml:space="preserve">
<value>Restore Defaults</value>
</data>
<data name="ButtonSaveSettings" xml:space="preserve">
<value>Save</value>
</data>
<data name="ButtonCancelSettingsChanges" xml:space="preserve">
<value>Cancel</value>
</data>
</root>
21 changes: 21 additions & 0 deletions TwitchDownloaderWPF/Translations/Strings.pl.resx
Original file line number Diff line number Diff line change
Expand Up @@ -786,4 +786,25 @@
<data name="OpenVideoInBrowser" xml:space="preserve">
<value>Open in browser</value>
</data>
<data name="ResetSettingsConfirmationMessage" xml:space="preserve">
<value>Are you sure you want to reset all settings to their default values?</value>
</data>
<data name="ResetSettingsConfirmation" xml:space="preserve">
<value>Restore Settings Confirmation</value>
</data>
<data name="TheApplicationMustBeRestartedMessage" xml:space="preserve">
<value>The application must be restarted for changes to take effect.</value>
</data>
<data name="RestartTheApplication" xml:space="preserve">
<value>Please restart {0}</value><comment>{0} is the name of the application.</comment>
</data>
<data name="ButtonRestoreDefaultSettings" xml:space="preserve">
<value>Restore Defaults</value>
</data>
<data name="ButtonSaveSettings" xml:space="preserve">
<value>Save</value>
</data>
<data name="ButtonCancelSettingsChanges" xml:space="preserve">
<value>Cancel</value>
</data>
</root>
21 changes: 21 additions & 0 deletions TwitchDownloaderWPF/Translations/Strings.resx
Original file line number Diff line number Diff line change
Expand Up @@ -785,4 +785,25 @@
<data name="OpenVideoInBrowser" xml:space="preserve">
<value>Open in browser</value>
</data>
<data name="ResetSettingsConfirmationMessage" xml:space="preserve">
<value>Are you sure you want to reset all settings to their default values?</value>
</data>
<data name="ResetSettingsConfirmation" xml:space="preserve">
<value>Restore Settings Confirmation</value>
</data>
<data name="TheApplicationMustBeRestartedMessage" xml:space="preserve">
<value>The application must be restarted for changes to take effect.</value>
</data>
<data name="RestartTheApplication" xml:space="preserve">
<value>Please restart {0}</value><comment>{0} is the name of the application.</comment>
</data>
<data name="ButtonRestoreDefaultSettings" xml:space="preserve">
<value>Restore Defaults</value>
</data>
<data name="ButtonSaveSettings" xml:space="preserve">
<value>Save</value>
</data>
<data name="ButtonCancelSettingsChanges" xml:space="preserve">
<value>Cancel</value>
</data>
</root>
21 changes: 21 additions & 0 deletions TwitchDownloaderWPF/Translations/Strings.ru.resx
Original file line number Diff line number Diff line change
Expand Up @@ -786,4 +786,25 @@
<data name="OpenVideoInBrowser" xml:space="preserve">
<value>Open in browser</value>
</data>
<data name="ResetSettingsConfirmationMessage" xml:space="preserve">
<value>Are you sure you want to reset all settings to their default values?</value>
</data>
<data name="ResetSettingsConfirmation" xml:space="preserve">
<value>Restore Settings Confirmation</value>
</data>
<data name="TheApplicationMustBeRestartedMessage" xml:space="preserve">
<value>The application must be restarted for changes to take effect.</value>
</data>
<data name="RestartTheApplication" xml:space="preserve">
<value>Please restart {0}</value><comment>{0} is the name of the application.</comment>
</data>
<data name="ButtonRestoreDefaultSettings" xml:space="preserve">
<value>Restore Defaults</value>
</data>
<data name="ButtonSaveSettings" xml:space="preserve">
<value>Save</value>
</data>
<data name="ButtonCancelSettingsChanges" xml:space="preserve">
<value>Cancel</value>
</data>
</root>
21 changes: 21 additions & 0 deletions TwitchDownloaderWPF/Translations/Strings.tr.resx
Original file line number Diff line number Diff line change
Expand Up @@ -787,4 +787,25 @@
<data name="OpenVideoInBrowser" xml:space="preserve">
<value>Open in browser</value>
</data>
<data name="ResetSettingsConfirmationMessage" xml:space="preserve">
<value>Are you sure you want to reset all settings to their default values?</value>
</data>
<data name="ResetSettingsConfirmation" xml:space="preserve">
<value>Restore Settings Confirmation</value>
</data>
<data name="TheApplicationMustBeRestartedMessage" xml:space="preserve">
<value>The application must be restarted for changes to take effect.</value>
</data>
<data name="RestartTheApplication" xml:space="preserve">
<value>Please restart {0}</value><comment>{0} is the name of the application.</comment>
</data>
<data name="ButtonRestoreDefaultSettings" xml:space="preserve">
<value>Restore Defaults</value>
</data>
<data name="ButtonSaveSettings" xml:space="preserve">
<value>Save</value>
</data>
<data name="ButtonCancelSettingsChanges" xml:space="preserve">
<value>Cancel</value>
</data>
</root>
21 changes: 21 additions & 0 deletions TwitchDownloaderWPF/Translations/Strings.uk.resx
Original file line number Diff line number Diff line change
Expand Up @@ -786,4 +786,25 @@
<data name="OpenVideoInBrowser" xml:space="preserve">
<value>Open in browser</value>
</data>
<data name="ResetSettingsConfirmationMessage" xml:space="preserve">
<value>Are you sure you want to reset all settings to their default values?</value>
</data>
<data name="ResetSettingsConfirmation" xml:space="preserve">
<value>Restore Settings Confirmation</value>
</data>
<data name="TheApplicationMustBeRestartedMessage" xml:space="preserve">
<value>The application must be restarted for changes to take effect.</value>
</data>
<data name="RestartTheApplication" xml:space="preserve">
<value>Please restart {0}</value><comment>{0} is the name of the application.</comment>
</data>
<data name="ButtonRestoreDefaultSettings" xml:space="preserve">
<value>Restore Defaults</value>
</data>
<data name="ButtonSaveSettings" xml:space="preserve">
<value>Save</value>
</data>
<data name="ButtonCancelSettingsChanges" xml:space="preserve">
<value>Cancel</value>
</data>
</root>
Loading

0 comments on commit 109cbae

Please sign in to comment.