Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/bicgstab null #1534

Merged
merged 11 commits into from
Jan 23, 2025
Merged

Hotfix/bicgstab null #1534

merged 11 commits into from
Jan 23, 2025

Conversation

maddyscientist
Copy link
Member

Hotfix PR that fixes the issue raised in #1532.

  • Avoid use of std::swap between x and y vectors as this is buggy
    • the owning vector containers still point to the original objects and so become invalid 🤮 )
  • When using initial guesses, the solution vector needs to be zeroed after residual has been computed
  • Remove redundant zeroing when fields are first allocated (any required zeroing is handled when solver is applied)

I've cherry picked the changes that allow GitHub actions to continue to work from #1497, as I assume this PR may be merged first.

Copy link
Contributor

@weinbe2 weinbe2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, awesome work @maddyscientist

Of note, as part of testing this I uncovered a few issues triggered by ctest that are unrelated to this PR; I'll file a separate issue for it momentarily.

@weinbe2 weinbe2 merged commit 18bf43e into develop Jan 23, 2025
6 of 7 checks passed
@weinbe2 weinbe2 deleted the hotfix/bicgstab-null branch January 23, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants