Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extendedGaugeResident up to date with gaugePrecise. #1528

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

SaltyChiang
Copy link
Contributor

Update extendedGaugeResident if gaugePrecise is modified. I add a function to do the work. After this change, we should expect that extendedGaugeResident is always the extended version of gaugePrecise.

Testings are required, hopefully CI/CD will do this for us.

@SaltyChiang SaltyChiang requested a review from a team as a code owner December 18, 2024 15:57
@maddyscientist
Copy link
Member

@weinbe2 can you test this with MILC when you get the chance please?

@maddyscientist
Copy link
Member

cscs-ci run

@weinbe2
Copy link
Contributor

weinbe2 commented Jan 14, 2025

Finally testing this, sorry for the hold-up @SaltyChiang . This technically needs develop merged in as well as a clang-format, plus some doxygen, but for simplicity I can also take care of that with one of my outstanding PR efforts...

@weinbe2
Copy link
Contributor

weinbe2 commented Jan 14, 2025

There's a small correctness issue somewhere that I'm seeing running MILC RHMC, namely the fermion contribution to the action at the very start of the evolution disagrees relative to develop. The gauge action and the momentum action contributions are fine at the start, but then also deviate later in the evolution.

I'll have to dig further into this and try to understand what's going awry...

@SaltyChiang
Copy link
Contributor Author

Thank you very much for the testing @weinbe2. I'll test the RHMC algorithm on my side.

@weinbe2
Copy link
Contributor

weinbe2 commented Jan 15, 2025

Thank you very much for the testing @weinbe2. I'll test the RHMC algorithm on my side.

If you can take point on testing this with MILC RHM[C/D] for now, I would appreciate it @SaltyChiang , and if you remain stuck I'll loop back to it tomorrow (Thursday) my time, would that work?

@weinbe2
Copy link
Contributor

weinbe2 commented Jan 23, 2025

@SaltyChiang fyi I'm getting back to testing your PR with MILC RHM[C/D] today

@weinbe2
Copy link
Contributor

weinbe2 commented Jan 23, 2025

Okay it looks like everything is actually good @SaltyChiang . Can you re-merge in develop and confirm your PR is 100% good with your own (R)HMC tests? If so, I'll do a fresh CI kick-off and assuming no issues I can hit merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants