-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaned up isWilson/isStaggered/isDwf/getStencilSteps routines #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it for each Dirac type, addresses #1098
…needs to implement it explicitly
…then added routines for each Dirac class to query it
maddyscientist
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from trivial comment, which can likely be ignored, this is good to go.
cscs-ci run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1098 and extends it to the
getStencilSteps
function as well, replacing various functions that look like this:And turning them intoDirac
abstract functions so each individual class is "forced" to define it so functions likeisWilsonType
, etc, don't need to be manually updated each time (or, more realistically, don't accidentally get forgotten).There are some other functions that could this be applied to,hermitian()
andhasSpecialMG()
, but it seemed reasonable to leave those as false unless proven otherwise.This PR now replaces those above functions with one-stop shop static
Dirac::[...]
functions that can query if variousQudaDslashType
orQudaDiracType
enums correspond to Wilson, dwf, or staggered operators. The variousDirac*
classes then query thesestatic
functions as appropriate. There is scope to apply these functions elsewhere in QUDA.This PR also fixes a small bug in split grid for staggered vs asqtad type fermions.