From 3256a7b785254432e946f978789b7bffd124f037 Mon Sep 17 00:00:00 2001 From: Heiko Klare Date: Wed, 25 Sep 2024 20:35:05 +0200 Subject: [PATCH] Find/replace dialog: properly update search string #2322 The find/replace dialog does currently not properly update its search string. When changing the search string and pressing return to execute a search, the previous search string is taken. The reason is an existing workaround for event handling of Combos in GTK. This change ensures that the search and replace input strings are properly updated upon every text modification in the according widgets. Fixes https://github.com/eclipse-platform/eclipse.platform.ui/issues/2322 --- .../src/org/eclipse/ui/texteditor/FindReplaceDialog.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceDialog.java b/bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceDialog.java index 456e51db8a7..e65cff7268e 100644 --- a/bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceDialog.java +++ b/bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceDialog.java @@ -139,12 +139,12 @@ private void ignoreNextEvent() { @Override public void modifyText(ModifyEvent e) { + modificationHandler.run(); // XXX: Workaround for Combo bug on Linux (see bug 404202 and bug 410603) if (fIgnoreNextEvent) { fIgnoreNextEvent = false; return; } - modificationHandler.run(); evaluateFindReplaceStatus(); updateButtonState(!findReplaceLogic.isActive(SearchOptions.INCREMENTAL));