Update MAILER config to use mailpit on L11 #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
tisnamuliarta
referenced
this pull request
in tisnamuliarta/laravel-shadcn
Mar 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [laravel/sail](https://togithub.com/laravel/sail) | `1.28.2` -> `1.29.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>laravel/sail (laravel/sail)</summary> ### [`v1.29.0`](https://togithub.com/laravel/sail/blob/HEAD/CHANGELOG.md#v1290---2024-03-08) [Compare Source](https://togithub.com/laravel/sail/compare/v1.28.2...v1.29.0) - Allow building sail to run PHP as root by [@​vmsh0](https://togithub.com/vmsh0) in [https://github.com/laravel/sail/pull/677](https://togithub.com/laravel/sail/pull/677) - Update MAILER config to use mailpit on L11 by [@​SamuelMwangiW](https://togithub.com/SamuelMwangiW) in [https://github.com/laravel/sail/pull/678](https://togithub.com/laravel/sail/pull/678) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tisnamuliarta/laravel-shadcn). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzguMSIsInVwZGF0ZWRJblZlciI6IjM3LjIzOC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Laravel 11 ships with the
logdriver as the default driver.In Laravel 10, the default
MAIL_PORTandMAIL_MAILERvalues matched the values expected to work with mailpit out of the box hence these values were not necessary to update.Running
php artisan sail:install --with mailpiton a fresh Laravel 11 project results in the following.envconfigThis still sends the emails to the log file for a user installing mailpit with sail in Laravel 11. This PR improves that DX by configuring the application to use mailpit by default for said users out of the box.