Wrong PHPDoc info for HasDownload::downloadResponseCallback

[alies-dev]

• Nova Version: latest 4, also v5.1.0

Description:

from \Laravel\Nova\Fields\HasDownload

    /**
     * The callback used to generate the download HTTP response.
     *
-    * @var (callable(\Laravel\Nova\Http\Requests\NovaRequest, \Laravel\Nova\Resource, ?string, ?string):(mixed))|null
+    * @var (callable(\Laravel\Nova\Http\Requests\NovaRequest, \Illuminate\Database\Eloquent\Model, ?string, ?string):(\Symfony\Component\HttpFoundation\Response|null)
     */
    public $downloadResponseCallback;

    /**
     * Specify the callback that should be used to create a download HTTP response.
     *
-    * @param  callable(\Laravel\Nova\Http\Requests\NovaRequest, \Laravel\Nova\Resource, ?string, ?string):mixed  $downloadResponseCallback
+    * @param  callable(\Laravel\Nova\Http\Requests\NovaRequest, \Illuminate\Database\Eloquent\Model, ?string, ?string):(\Symfony\Component\HttpFoundation\Response|null)  $downloadResponseCallback 
     * @return $this
     */
    public function download(callable $downloadResponseCallback)
    {
        $this->downloadResponseCallback = $downloadResponseCallback;

        return $this;
    }

The only place where downloadResponseCallback called is \Laravel\Nova\Fields\HasDownload::toDownloadResponse():

    /**
     * Create an HTTP response to download the underlying field.
     */
    public function toDownloadResponse(NovaRequest $request, Resource $resource): Response|StreamedResponse
    {
        return call_user_func(
            $this->downloadResponseCallback,
            $request,
            $resource->resource,
            $this->getStorageDisk(),
            $this->getStoragePath()
        );
    }

It will be also nice to utilize more generics syntax for Psalm/PHPStan, but it will be nice to have at least this minor fix

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.