-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] SummaryReader #577
base: master
Are you sure you want to change the base?
[WIP] SummaryReader #577
Conversation
Thanks for your contribution! Three issues come to my mind:
Personally, I want to save all images of an experiment. <- maybe too much data. SummaryReader(filename, build_index=True)
encoded_images = reader.read_image('my_tag')
encoded_image = reader.read_image('my_tag', global_step=5)
encoded_image = reader.read_image('my_tag', global_step=7)
image = reader.read_image_as_numpy('my_tag', global_step=8)
SummaryReader(filename, build_index=False)
filenames = reader.read_image('my_tag', dump=True)
filenames = reader.dump_images('my_tag') # I think it's better What are your use cases? |
Thanks for your feedback. My main goal so far was to replace the Regarding your questions:
|
Hey @dsuess thanks for the PR! Our team is also very interested in this feature. I'm wondering are you still working on it and is there an ETA? |
Hi @kaiwenw, I'd love to keep working on this. What are your use cases? Currently, it's a bit rough and limited, but it does what I need. |
Hi @dsuess, we usually need to retrieve the end of the log, mostly for debugging purposes. For ex. we have hard cutoffs in integration tests, and it would be nice to retrieve end of log programmatically in Notebook as well. As for data types, probably just need a list of scalars, histograms and maybe embeddings. (no images or audio needed) |
The missing support for reading tensorboard files was raised in #318. This PR adds support for iterating over tensorboard files. It's currently work-in-progress and I want to use this PR to discuss further development.
Currently,
SummaryReader
reads a single tfevents file and yields the parsed Event protobuf objects similar to thesummary_iterator
function fromtensorflow.python.summary.summary_iterator
. Under the hood, I use a refactored version ofPyRecordReader_New
fromtensorboard.compat.tensorflow_stub.pywrap_tensorflow
to iterate over the records andSummaryReader
only parses the protobuf Events.How should we continue from here? One thing I wasn't sure about is whether we want to keep the current interface or convert the Event-objects into more pythonic objects, e.g. dicts.