Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs fix #575

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Docs fix #575

merged 3 commits into from
Feb 4, 2025

Conversation

bwohlberg
Copy link
Collaborator

@bwohlberg bwohlberg commented Jan 29, 2025

Docs fix and add utility function.

@bwohlberg bwohlberg added the documentation Improvements or additions to documentation label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.57%. Comparing base (c4ebb68) to head (14acf0c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
+ Coverage   93.56%   93.57%   +0.01%     
==========================================
  Files          92       92              
  Lines        6105     6111       +6     
==========================================
+ Hits         5712     5718       +6     
  Misses        393      393              
Flag Coverage Δ
unittests 93.57% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +453 to +454
angles: Array of projection angles in radians.
vectors: Array of geometry specification vectors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly confusing that you can specify both of these, but (I think) only one ever gets used.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make an issue to note that this needs to be addressed.

@bwohlberg bwohlberg merged commit a0e99bd into main Feb 4, 2025
19 checks passed
@bwohlberg bwohlberg deleted the brendt/docs-fix branch February 4, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants