From 48dcba00653dd39501d7fe9a2a15c403ac6b4f94 Mon Sep 17 00:00:00 2001 From: Michael-T-McCann Date: Thu, 19 Sep 2024 12:48:14 -0600 Subject: [PATCH 1/3] Add caveat --- scico/linop/xray/_xray.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scico/linop/xray/_xray.py b/scico/linop/xray/_xray.py index 04bdabe8..75f035af 100644 --- a/scico/linop/xray/_xray.py +++ b/scico/linop/xray/_xray.py @@ -235,6 +235,9 @@ def _calc_weights( class XRayTransform3D(LinearOperator): r"""General-purpose, 3D, parallel ray X-ray projector. + Warning: This class is experimental and may be up to ten times slower + than :class:`scico.linop.xray.astra.XRayTransform3D`. + For each view, the projection geometry is specified by an array with shape (2, 4) that specifies a :math:`2 \times 3` projection matrix and a :math:`2 \times 1` offset vector. Denoting the matrix From 10128bf792d106ad553a2190ecf633825af90f7c Mon Sep 17 00:00:00 2001 From: Michael-T-McCann Date: Mon, 23 Sep 2024 11:01:02 -0600 Subject: [PATCH 2/3] Try #2 --- scico/linop/xray/_xray.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scico/linop/xray/_xray.py b/scico/linop/xray/_xray.py index 75f035af..5e9caa61 100644 --- a/scico/linop/xray/_xray.py +++ b/scico/linop/xray/_xray.py @@ -235,6 +235,11 @@ def _calc_weights( class XRayTransform3D(LinearOperator): r"""General-purpose, 3D, parallel ray X-ray projector. + This projector approximates cubical voxels projecting onto + rectangular pixels and provides a back projector that is the true + adjoint of the forward projector. It is written purely in JAX, + allowing it to run on either CPU or GPU and minimizing host copies. + Warning: This class is experimental and may be up to ten times slower than :class:`scico.linop.xray.astra.XRayTransform3D`. From cbf1b90d3ff079265af206a177ce64d24b73753f Mon Sep 17 00:00:00 2001 From: Michael-T-McCann Date: Mon, 23 Sep 2024 12:24:31 -0600 Subject: [PATCH 3/3] Rephrase --- scico/linop/xray/_xray.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scico/linop/xray/_xray.py b/scico/linop/xray/_xray.py index 5e9caa61..770bf627 100644 --- a/scico/linop/xray/_xray.py +++ b/scico/linop/xray/_xray.py @@ -235,8 +235,8 @@ def _calc_weights( class XRayTransform3D(LinearOperator): r"""General-purpose, 3D, parallel ray X-ray projector. - This projector approximates cubical voxels projecting onto - rectangular pixels and provides a back projector that is the true + This projector approximates cubic voxels projecting onto + rectangular pixels and provides a back projector that is the exact adjoint of the forward projector. It is written purely in JAX, allowing it to run on either CPU or GPU and minimizing host copies.