Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality Assurance - QA Stages, Formatting, Guidelines and Web Quality Assurance Handbook #95

Merged
merged 27 commits into from
Aug 14, 2019

Conversation

MaxHarrisonGit
Copy link
Contributor

Description

This PR Includes QA Stages, Formatting, Guidelines and Web Quality Assurance Handbook for Quality Assurance.

  • QA Stages are at what point and stage should the Project be Tested.
  • Formatting is how should the tests, results, and bugs be formatted and created.
  • Guidelines is what needs to be followed either for QA or for Devs building with QA in mind.
  • Web Quality Assurance Handbook is to outline and mark the Quality we expect for a Website that is entering QA.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds documentation)
  • [ x] Breaking change (This is a significant change)

Checklist

  • [x ] I have ensured that I have used relative links where appropriate.
  • [ x] I have proofread my documentation.

Copy link
Contributor

@AlexCatch AlexCatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this a great bit of content, I only disagree with one point which I commented on.

The only issues I could find with it are styling / spelling / punctuation and flow.

Can we just go over the PR and make sure we don't have capital letters in the middle of sentences & that the flow makes sense when reading it back.

I also believe there is an open PR from Jared which more closely integrates the Web Quality Assurance side so I'm not sure how we'd proceed with that.

Overall great bit of work - just needs some polishing & more discussion from the rest of the team 😄 👍

Copy link
Contributor

@dextermb dextermb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bad document overall. I've suggested some changes, so if you want you can implement them with a single button click. I've also reworded some sections.

Copy link
Contributor

@AlexCatch AlexCatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gone over it once more with a few suggestions, just like Dex's you should be able to just accept the suggestions and it they will be automatically applied.

Could we have the file names have dashes in-lieu of no seperators in file names please? Would make it look a fair bit cleaner.

Copy link
Contributor

@ash123456789 ash123456789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

dextermb
dextermb previously approved these changes Dec 20, 2018
@dextermb
Copy link
Contributor

It's also worth noting that our git workflow says that commits should be commands: updated -> update 👍

@AlexCatch
Copy link
Contributor

AlexCatch commented Dec 21, 2018

@wheatleyjj What's the next steps here are this includes the web quality assurance guide that is currently open at #94 ?

ash123456789
ash123456789 previously approved these changes Dec 21, 2018
@jaredkove
Copy link
Contributor

@AlexCatch If this gets approved first then I presume this one goes in and my efforts are semi-wasted.

@dextermb
Copy link
Contributor

@AlexCatch If this gets approved first then I presume this one goes in and my efforts are semi-wasted.

🌈 Nothing is a waste

@AlexCatch
Copy link
Contributor

@MaxHarrisonGit As we've made fair amount of changes in #94 IMO the web quality assurance guide should be removed from this PR & when the PR @wheatleyjj made has been merged in links can be updated etc.

What do you think about this?

@MaxHarrisonGit
Copy link
Contributor Author

@AlexCatch I am fine with this, will remove it now 😄

@MaxHarrisonGit MaxHarrisonGit dismissed stale reviews from ash123456789 and dextermb via fcbe269 December 21, 2018 09:16
Copy link
Contributor

@dextermb dextermb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not forget about the QA book for too long

@DivineOmega
Copy link
Contributor

I believe we should get this both PR (#95) and @wheatleyjj's related PR (#94) merged in shortly, and resolve any conflicts as necessary.

@DivineOmega DivineOmega requested a review from robmilward August 14, 2019 15:42
@DivineOmega DivineOmega merged commit 8ca5830 into langleyfoxall:master Aug 14, 2019
@DivineOmega
Copy link
Contributor

As has been discussed with a few people, this PR does currently contain a QA process different to how we currently work. Now this is outside of @MaxHarrisonGit's fork, feel free to make PRs that amend this.

@robmilward robmilward mentioned this pull request Aug 15, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants