-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quality Assurance - QA Stages, Formatting, Guidelines and Web Quality Assurance Handbook #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this a great bit of content, I only disagree with one point which I commented on.
The only issues I could find with it are styling / spelling / punctuation and flow.
Can we just go over the PR and make sure we don't have capital letters in the middle of sentences & that the flow makes sense when reading it back.
I also believe there is an open PR from Jared which more closely integrates the Web Quality Assurance side so I'm not sure how we'd proceed with that.
Overall great bit of work - just needs some polishing & more discussion from the rest of the team 😄 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a bad document overall. I've suggested some changes, so if you want you can implement them with a single button click. I've also reworded some sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gone over it once more with a few suggestions, just like Dex's you should be able to just accept the suggestions and it they will be automatically applied.
Could we have the file names have dashes in-lieu of no seperators in file names please? Would make it look a fair bit cleaner.
Co-Authored-By: MaxHarrisonGit <maxharrison@ntlworld.com>
Co-Authored-By: MaxHarrisonGit <maxharrison@ntlworld.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
It's also worth noting that our git workflow says that commits should be commands: |
@wheatleyjj What's the next steps here are this includes the web quality assurance guide that is currently open at #94 ? |
@AlexCatch If this gets approved first then I presume this one goes in and my efforts are semi-wasted. |
🌈 Nothing is a waste |
@MaxHarrisonGit As we've made fair amount of changes in #94 IMO the web quality assurance guide should be removed from this PR & when the PR @wheatleyjj made has been merged in links can be updated etc. What do you think about this? |
@AlexCatch I am fine with this, will remove it now 😄 |
fcbe269
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not forget about the QA book for too long
As has been discussed with a few people, this PR does currently contain a QA process different to how we currently work. Now this is outside of @MaxHarrisonGit's fork, feel free to make PRs that amend this. |
Description
This PR Includes QA Stages, Formatting, Guidelines and Web Quality Assurance Handbook for Quality Assurance.
Types of changes
Checklist