Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: langfuse trace get the right parent span #6844

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tianzhipeng-git
Copy link
Contributor

the tracing event(called span in langfuse) was not organized rightly.
we should get the last not closed span as parent, so use OrderedDict to maintain the un closed span

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Feb 26, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 26, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 26, 2025
@tianzhipeng-git
Copy link
Contributor Author

fix issue #6846

Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #6844 will improve performances by 48.39%

Comparing tianzhipeng-git:langfuse_parent_span (4952662) with main (0134485)

Summary

⚡ 1 improvements
✅ 18 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_cancel_nonexistent_build 13.2 ms 8.9 ms +48.39%

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 27, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 27, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 27, 2025
@italojohnny italojohnny self-requested a review February 27, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants