Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Send request origin in AgentQL request Headers #6734

Closed

Conversation

wjwjtf
Copy link

@wjwjtf wjwjtf commented Feb 20, 2025

This pull request includes a small change to the src/backend/base/langflow/components/agentql/agentql_api.py file. The change adds a new header to the build_output method to specify the request origin.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 20, 2025
@ogabrielluiz ogabrielluiz changed the title Send request origin in AgentQL request Headers fix: Send request origin in AgentQL request Headers Feb 20, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 20, 2025
@ogabrielluiz
Copy link
Contributor

LGTM!

Thanks @wjwjtf

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 20, 2025
@edwinjosechittilappilly
Copy link
Collaborator

@Cristhianzl
I have also suggested that @wjwjtf update the relevant templates.
Can you check if there are any other issues for the playwright tests to fail?

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 21, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 24, 2025
auto-merge was automatically disabled February 24, 2025 19:58

Head branch was pushed to by a user without write access

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 24, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 24, 2025
Copy link

codspeed-hq bot commented Feb 24, 2025

CodSpeed Performance Report

Merging #6734 will degrade performances by 36.3%

Comparing wjwjtf:wenjie/send_agentql_requests_correctly (30190ac) with main (0134485)

Summary

❌ 1 regressions
✅ 18 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_build_flow_invalid_job_id 8 ms 12.5 ms -36.3%

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 24, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 24, 2025
@github-actions github-actions bot removed the bug Something isn't working label Feb 24, 2025
@github-actions github-actions bot added the bug Something isn't working label Feb 24, 2025
@wjwjtf wjwjtf force-pushed the wenjie/send_agentql_requests_correctly branch from 66e643f to 22cf592 Compare February 24, 2025 22:26
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Feb 24, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 24, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 26, 2025
@edwinjosechittilappilly
Copy link
Collaborator

This Should be Good to go!

Let me test it and shall let you know!

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 26, 2025
Copy link
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwinjosechittilappilly
Copy link
Collaborator

@wjwjtf can we close this PR since you had opened a new PR #6833

@wjwjtf wjwjtf closed this Feb 27, 2025
@wjwjtf wjwjtf deleted the wenjie/send_agentql_requests_correctly branch February 27, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants