Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Needle Search Tool With Template #6648

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

JANHMS
Copy link
Contributor

@JANHMS JANHMS commented Feb 15, 2025

Overview

Adding Needle as a Tool to Langflow to enable dynamic integration with other tools e.g. CrewAI. While the existing Needle Bundle provides comprehensive but static search across data sources, this new component offers a flexible tool-based approach, complementing the current functionality.

Dependency

Adding top_k as a param to the Langchain integration:
langchain-ai/langchain#29821

Invoice Summarizer Template using Langflow Agent

Screenshot 2025-02-27 at 3 47 31 PM

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Feb 15, 2025
Copy link
Contributor

autofix-ci bot commented Feb 15, 2025

Hi! I'm autofix logoautofix.ci, a bot that automatically fixes trivial issues such as code formatting in pull requests.

I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:

  1. Allow edits by maintainers for your pull request, and then re-trigger CI (for example by pushing a new commit).
  2. Manually fix the issues identified for your pull request (see the GitHub Actions output for details on what I would like to change).

@JANHMS JANHMS changed the title Needle Search Tool With Template feat: Needle Search Tool With Template Feb 15, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 15, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 16, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 16, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 16, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 16, 2025
@JANHMS
Copy link
Contributor Author

JANHMS commented Feb 17, 2025

@ogabrielluiz

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 19, 2025
Copy link

codspeed-hq bot commented Feb 19, 2025

CodSpeed Performance Report

Merging #6648 will degrade performances by 18.47%

Comparing needle-ai:main (87090eb) with main (6017677)

Summary

❌ 1 regressions
✅ 18 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_cancel_nonexistent_build 7.9 ms 9.6 ms -18.47%

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 20, 2025
@JANHMS
Copy link
Contributor Author

JANHMS commented Feb 26, 2025

Made the changes in the template using the Langflow agent instead of CrewAi. @edwinjosechittilappilly

Copy link
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work!
can we utilise the existing component in tool mode wouldn't that solve the issue do we need a new component for it?

I have opened a PR to add tool mode in Needle Component.
I hope that helps.

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 27, 2025
@JANHMS
Copy link
Contributor Author

JANHMS commented Feb 27, 2025

@edwinjosechittilappilly I made the changes here. I can not push to the PR that you opened, since I am only allowed to use forked PRs as a contributor. I will finish this up here now with lint issues etc. Should be ready to be merged today.

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 27, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 27, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 27, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 27, 2025
@edwinjosechittilappilly
Copy link
Collaborator

Can you make the PR editable by the maintainer?

@JANHMS
Copy link
Contributor Author

JANHMS commented Feb 28, 2025

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants