Fix build

langchain-ai · Jan 21, 2025 · f7f7944 · f7f7944
1 parent bd9ca1a
commit f7f7944
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/langchain-core/src/language_models/chat_models.ts b/langchain-core/src/language_models/chat_models.ts
@@ -9,6 +9,8 @@ import {
   coerceMessageLikeToMessage,
   AIMessageChunk,
   isAIMessageChunk,
+  isBaseMessage,
+  isAIMessage,
 } from "../messages/index.js";
 import type { BasePromptValueInterface } from "../prompt_values.js";
 import {
@@ -48,7 +50,6 @@ import { concat } from "../utils/stream.js";
 import { RunnablePassthrough } from "../runnables/passthrough.js";
 import { isZodSchema } from "../utils/types/is_zod_schema.js";
 import { callbackHandlerPrefersStreaming } from "../callbacks/base.js";
-import { isAIMessage, isBaseMessage } from "../../messages.js";
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export type ToolChoice = string | Record<string, any> | "auto" | "any";
@@ -351,7 +352,7 @@ export abstract class BaseChatModel<
       messageList.map(coerceMessageLikeToMessage)
     );
 
-    let runManagers;
+    let runManagers: CallbackManagerForLLMRun[] | undefined;
     if (existingRunManagers !== undefined && existingRunManagers.length > 0) {
       if (existingRunManagers.length !== baseMessages.length) {
         throw new Error(

diff --git a/langchain-core/src/language_models/llms.ts b/langchain-core/src/language_models/llms.ts
@@ -243,7 +243,7 @@ export abstract class BaseLLM<
     handledOptions: BaseCallbackConfig,
     existingRunManagers?: CallbackManagerForLLMRun[]
   ): Promise<LLMResult> {
-    let runManagers;
+    let runManagers: CallbackManagerForLLMRun[] | undefined;
     if (existingRunManagers !== undefined && existingRunManagers.length > 0) {
       if (existingRunManagers.length !== prompts.length) {
         throw new Error(

diff --git a/libs/langchain-openai/src/tests/chat_models.int.test.ts b/libs/langchain-openai/src/tests/chat_models.int.test.ts
@@ -579,6 +579,12 @@ test("ChatOpenAI can cache generations", async () => {
   expect(lookupSpy).toHaveBeenCalledTimes(2);
   expect(updateSpy).toHaveBeenCalledTimes(2);
 
+  const res2 = await chat.generate([[message], [message]]);
+  expect(res2.generations.length).toBe(2);
+
+  expect(lookupSpy).toHaveBeenCalledTimes(4);
+  expect(updateSpy).toHaveBeenCalledTimes(2);
+
   lookupSpy.mockRestore();
   updateSpy.mockRestore();
 });