Fix: Allow Redis addDocuments without overriding existing keys (#1555)

* Fix: Allow Redis addDocuments without overriding existing keys

* Update redis.ts

* Revert "Update redis.ts"

This reverts commit 1d2c030.

* Revert "Revert "Update redis.ts""

This reverts commit 2ad93cf.

* Update fix

* Fix test

---------

Co-authored-by: jacoblee93 <jacoblee93@gmail.com>

langchain/src/vectorstores/redis.ts

@@ -159,10 +159,15 @@ export class RedisVectorStore extends VectorStore {
     // check if the index exists and create it if it doesn't
     await this.createIndex(vectors[0].length);
 
+    const info = await this.redisClient.ft.info(this.indexName);
+    const lastKeyCount = parseInt(info.numDocs, 10) || 0;
     const multi = this.redisClient.multi();
 
     vectors.map(async (vector, idx) => {
-      const key = keys && keys.length ? keys[idx] : `${this.keyPrefix}${idx}`;
+      const key =
+        keys && keys.length
+          ? keys[idx]
+          : `${this.keyPrefix}${idx + lastKeyCount}`;
       const metadata =
         documents[idx] && documents[idx].metadata
           ? documents[idx].metadata
@@ -284,6 +289,12 @@ export class RedisVectorStore extends VectorStore {
     try {
       await this.redisClient.ft.info(this.indexName);
     } catch (err) {
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      if ((err as any)?.message.includes("unknown command")) {
+        throw new Error(
+          "Failed to run FT.INFO command. Please ensure that you are running a RediSearch-capable Redis instance: https://js.langchain.com/docs/modules/data_connection/vectorstores/integrations/redis#setup"
+        );
+      }
       // index doesn't exist
       return false;
     }

langchain/src/vectorstores/tests/redis.int.test.ts

@@ -9,12 +9,10 @@ import { OpenAIEmbeddings } from "../../embeddings/openai.js";
 import { RedisVectorStore } from "../redis.js";
 import { Document } from "../../document.js";
 
-describe.skip("RedisVectorStore", () => {
+describe("RedisVectorStore", () => {
   let vectorStore: RedisVectorStore;
 
   beforeEach(async () => {
-    expect(process.env.REDIS_URL).toBeDefined();
-
     const client = createClient({ url: process.env.REDIS_URL });
     await client.connect();
 

langchain/src/vectorstores/tests/redis.test.ts

@@ -9,7 +9,9 @@ const createRedisClientMockup = () => {
 
   return {
     ft: {
-      info: jest.fn(),
+      info: jest.fn<any>().mockResolvedValue({
+        numDocs: 0,
+      }),
       create: jest.fn(),
       search: jest.fn<any>().mockResolvedValue({
         total: 0,

test-int-deps-docker-compose.yml

@@ -1,7 +1,7 @@
 version: '3.8'
 services:
   redis:
-    image: redis:6.2-alpine
+    image: redis/redis-stack-server:latest
     restart: always
     ports:
       - '6379:6379'