-
Notifications
You must be signed in to change notification settings - Fork 16.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate langhchain community ucfunctiontoolkit in favor for databricks_langchain #29746
Deprecate langhchain community ucfunctiontoolkit in favor for databricks_langchain #29746
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
9862260
to
e840a29
Compare
@deprecated( | ||
since="0.3.18", | ||
removal="1.0", | ||
alternative_import="databricks_langchain.uc_ai.UCFunctionToolkit", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use unitycatalog-langchain package? databricks_langchain.uc_ai imports from it and it doesn't seem needed to rely on another package (databricks-langchain) here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Eric, we wanted all the imports to be from one place so its easier for users to just install and know about 1 package. That is why we re-exported from databricks-ai-bridge package. So I guess documenting only one package makes sense. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to the direction of a single package interface. In the backend, we're using unitycatalog-langchain for the toolkit implementation. Having everything all go through a unified namespace of databricks.ai
makes a ton of sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After switching to unitycatalog-langchain package it's all good!
e840a29
to
0d07831
Compare
0d07831
to
9e7257b
Compare
9e7257b
to
afec81f
Compare
Thank you for contributing to LangChain!
PR title: "package: description"
PR message: Delete this entire checklist and replace with
Add tests and docs: If you're adding a new integration, please include
docs/docs/integrations
directory.Lint and test: Run
make format
,make lint
andmake test
from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.