Unable to import FlowAccumulator

[mcflugen]

It appears that the flow direction and accumulation tutorials are not working with the latest landlab release. The error that I get is,

>>> from landlab.components import FlowAccumulator 
ImportError: cannot import name FlowAccumulator

I think the problem is probably just that the tutorials under flow_direction_and_accumulation were written for the development version of landlab that's in master - not the latest release (v1.0.3). I propose we move these tutorials to a new branch (and remove them from master) until we have a new release that fixes this problem.

All the tutorials on the master branch should work with the latest released version of landlab. (at least that's what I remember us agreeing to)

Or we could do something like we do with landlab and have a release branch with tags that point to the version of landlab that the tutorials work with and have master work with the development version of landlab. But that that's another issue.

[kbarnhart]

These three tutorials are all in the most recent PR (#7), so I think that all we'd need to do to remove them is to (1) revert the PR and (2) remove the links to these tutorials that I added in the documentation.

Does that sound reasonable?

[mcflugen]

That could work but it might be easier to just create a new branch off of the tip of master and then remove the flow_direction_and_accumulation folder in master. Things are complicated slightly because I'm working off of a branch that was created post-merge of #7. I'm up for whatever you decide, though.

[nicgaspar]

I think @mcflugen is correct - we decided that tutorials should work with the current release. I didn't exactly follow the discussion after this point though.

Do you mean having a branch on tutorials for tutorials that utilize new code that we build that is not compatible with the current release? This just requires people to remember to merge back their branches when a new release is issued. But I might not be following.

[mcflugen]

@nicgaspar: You're following correctly. I'm thinking new tutorials should be added in a feature branch and not merged back into the master branch until they are compatible with the current version of landlab.

[nicgaspar]

I think that could be fine - assuming we all remember to merge back our branches. I am forgetful.

[mcflugen]

Me too.

I think the workflow could be:

• Create a new branch for your tutorial
• Add your tutorial notebook
• Once the tutorial works with the development version of landlab, create a pull request

In cases where the new tutorial doesn't work with the latest version, but does work with the development version, we wait to merge the new tutorial until we have a new release that works. This way we'll have a reminder that there are tutorials out there waiting to be merged and only one person from our group needs to remember to check for outstanding pull requests.

[nicgaspar]

I like it. A tutorial czar.

[kbarnhart]

I think we can do the following now:

1. delete Master,
2. remove the exceptions part of testing that ignores the flow direction tutorials
3. close this issue?

[kbarnhart]

Following onto this thread. A few thoughts:

1. I think we need to get rid of master in this repo since it confuses even me...

If I do a compare on master and release it shows they are the same. OK to delete it?

2. PR Update testing procedures #33 changes how the testing is done and actually makes sure that merges into release work with release and merges into next work with the landlab development branch master.

(this PR is still in development)