Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scala-native dependencies #26

Merged
merged 5 commits into from
Dec 23, 2023
Merged

Update scala-native dependencies #26

merged 5 commits into from
Dec 23, 2023

Conversation

natsukagami
Copy link
Contributor

@natsukagami natsukagami commented Dec 12, 2023 •
edited
Loading

  • Move scala-native pinned version to latest main commit
  • Remove munit loop patch as it has been reverted on scala-native
  • Immix GC might work now unfortunately not

@natsukagami
Update scala-native dependencies
3d774b3 
- Move scala-native pinned version to latest main commit
- Remove munit loop patch as it has been reverted on scala-native
- Immix GC might work now
@natsukagami
Update snapshot commit of munit in build.sbt
c3d1c36
@natsukagami natsukagami marked this pull request as ready for review December 15, 2023 14:11
@m8nmueller
Copy link
Contributor

LGTM and runs on my computer. You wanted to write high-usage tests to check whether GC actually works. How is that going? Otherwise, I don't have any opinion on this.

@natsukagami natsukagami marked this pull request as draft December 19, 2023 16:36
@natsukagami
Re-add Boehm GC usage
8e33d12 
... to avoid problems with the Immix GC for now.
@natsukagami
Copy link
Contributor Author

@m8nmueller unfortunately I made a mistake and force-pushed away the commit used in main for munit, so new users trying to clone the repo might not be able to set it up anymore. Let's get this in first, with the Boehm GC remained on.

@natsukagami natsukagami marked this pull request as ready for review December 22, 2023 14:33
@natsukagami natsukagami merged commit 43df667 into lampepfl:main Dec 23, 2023
3 checks passed
@natsukagami natsukagami deleted the update-pinned-deps branch January 17, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m8nmueller m8nmueller Awaiting requested review from m8nmueller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natsukagami @m8nmueller