Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.3 support. Mark package abandoned. #112

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

Xerkus
Copy link
Member

@Xerkus Xerkus commented Nov 24, 2023

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

This package was introduced to simplify migration from Zend Framework packages to Laminas. In a month it will be 4 years since Zend Framework migrated to Laminas. None of Zend Framework packages support php 8 and none of supported Laminas packages support php <8.

If users still depend on this package they are strongly urged to complete migration and remove this dependency.

Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
@Xerkus Xerkus added this to the 1.8.0 milestone Nov 24, 2023
@froschdesign froschdesign changed the title Add php 8.3 support. Mark package abandoned. Add PHP 8.3 support. Mark package abandoned. Nov 24, 2023
@Xerkus Xerkus merged commit eb0d96c into laminas:1.8.x Nov 24, 2023
11 checks passed
@Xerkus Xerkus deleted the feature/php83 branch November 24, 2023 13:56
@Xerkus
Copy link
Member Author

Xerkus commented Sep 12, 2024

composer's abandoned flag is not the same as not receiving security patches.

@froschdesign
Copy link
Member

But we do not use the "abandoned" flag in the Composer configuration for security-only packages, only if they are archived: https://github.com/laminas/laminas-crypt
At least that has been the procedure so far.

@Xerkus
Copy link
Member Author

Xerkus commented Sep 12, 2024

It is not really limited to archived repos. In this case we discussed in the slack if bridge should receive new php version support and if we should mark it abandoned to encourage people to stop relying on it if they still do. General consensus was what we have here.

Abandoned flag in composer is merely informational. It is getting noticed so it works as intended.

If someone does not need the bridge but it is a transient dependency then same approach can be taken as we used in the first years after migration to Laminas. Add replace to the root composer.json of the application:

    "replace": {
        "laminas/laminas-zendframework-bridge": "*"
    },

Bigger issue here is that api-tools are not marked as abandoned but entirely discontinued.

@froschdesign
Copy link
Member

I think the whole thing needs to be better documented, otherwise the question will keep coming up.

Bigger issue here is that api-tools are not marked as abandoned but entirely discontinued.

That is true.

@Xerkus
Copy link
Member Author

Xerkus commented Sep 12, 2024

May be add it to the README since there is no web documentation.

@froschdesign
Copy link
Member

I think we should automate the creation of the readme file. The relevant data are already available in the Composer configuration file and in the repository (custom properties).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants