-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dummy
feature for non supported platforms
#39
Conversation
Warning Rate Limit Exceeded@lambdalisue has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 50 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe project's CI/CD pipeline has been updated with newer versions of GitHub Actions for checking out code and caching. A new job for building a dummy target has been introduced, likely for testing or CI purposes. The source code has been modified to include conditional compilation, enhancing support for different operating systems and feature flags. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit's AI:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- Cargo.toml
Files selected for processing (5)
- .github/workflows/audit.yml (1 hunks)
- .github/workflows/build.yml (2 hunks)
- .github/workflows/test.yml (3 hunks)
- README.md (2 hunks)
- src/collector.rs (3 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/audit.yml
- .github/workflows/test.yml
Additional comments: 6
.github/workflows/build.yml (1)
- 12-13: The update of the GitHub Actions versions for checkout and caching is noted and aligns with the PR objectives to use the latest tools.
src/collector.rs (3)
44-50: The conditional compilation directives added to the
collect
function for thedummy
feature are correct and follow Rust's standard practices for feature flags.65-67: The test
test_collect_internal_ok
is correctly configured for macOS, Linux, and Windows platforms. However, ensure that the test is not accidentally excluded on any platform due to the cfg attributes.85-102: The test
test_collect_internal_ok_dummy
is correctly set up to test thedummy
feature. It checks that all metrics areNone
, which is the expected behavior for the dummy collector.README.md (2)
51-53: The README has been updated to include information about the
dummy
feature, which is helpful for users who need to compile on non-supported platforms.124-128: The feature table in the README clearly explains the
dummy
feature, which aligns with the changes made in the source code.
4bf4a72
to
284f608
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=======================================
Coverage 57.75% 57.75%
=======================================
Files 5 5
Lines 258 258
=======================================
Hits 149 149
Misses 109 109 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- Cargo.toml
Files selected for processing (6)
- .github/workflows/audit.yml (1 hunks)
- .github/workflows/build.yml (2 hunks)
- .github/workflows/test.yml (3 hunks)
- README.md (2 hunks)
- src/collector.rs (4 hunks)
- src/collector/dummy.rs (1 hunks)
Files skipped from review as they are similar to previous changes (5)
- .github/workflows/audit.yml
- .github/workflows/build.yml
- .github/workflows/test.yml
- README.md
- src/collector.rs
Additional comments: 1
src/collector/dummy.rs (1)
- 3-5: The implementation of the
collect
function, which returns a defaultMetrics
object, appears to be correct and straightforward.
Based on the discussion in #36, we decided to add a `dummy` feature that always return an empty `Metrics` for non supported platforms.
From #36
Summary by CodeRabbit
Summary by CodeRabbit
Chores
New Features
build-dummy
job in the build workflow to enhance the build process and testing for specific targets.Documentation
README.md
to reflect the latest changes and usage instructions.Tests
collector.rs
to ensure compatibility and correctness across different operating systems and feature flags.