[CONFIGURATOR] Versioning + UI #1013
Conversation
Nico-Sanchez
changed the title
Nico-Sanchez
force-pushed
the
create-new-settings-version-table
branch
from
8e125da to
79ee94e
Compare
- Reorganize schemas and tables constraints (version_id) - Add Version associations (and assoc changesets) - Allow new config version creation in UI (update forms)
Nico-Sanchez
force-pushed
the
create-new-settings-version-table
branch
from
b6f5d9e to
2f70766
Compare
There was a problem hiding this comment.
Great work Nico!! Although the PR is big, it adds a lot of things that were needed for the configurator.
Regarding the UX for the version creation and the problem it has now, probably we should make the user create the things in the order we want to, for example, if Characters depends on Skills, lets set the skills first then the characters later, so we can use the updated skills from these version and not the previous one 😄. We can address it in another PR
| |> cast_assoc(:consumable_items) | ||
| |> cast_assoc(:skills, with: &Skill.assoc_changeset/2) | ||
| |> cast_assoc(:map_configurations, with: &MapConfiguration.assoc_changeset/2) | ||
| |> cast_assoc(:game_configuration, with: &GameConfiguration.assoc_changeset/2) |
There was a problem hiding this comment.
We might want to add a unique_constraint for the name because otherwise this could happen very easily
There was a problem hiding this comment.
As we discussed at the office, we'll address this in the future.
We might want to "soft-delete" a version and re-use that name. Also, the feature is quite lax for now, we can modify everything and move to any version.
After we use it, we'll know better how to make this feature more secure and restrictive in a useful way to our needs.
Motivation
This is part of #1002
Closes #1029
Closes #1030
Summary of changes
How to test it?
To create a new version:
What to check:
Known issues and next steps:
#1028
Checklist