Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: persist gossip attestation state #1136

Merged
merged 18 commits into from
Jun 14, 2024
Merged

refactor: persist gossip attestation state #1136

merged 18 commits into from
Jun 14, 2024

Conversation

avilagaston9
Copy link
Contributor

@avilagaston9 avilagaston9 commented Jun 6, 2024 •
edited
Loading

  • Persists Gossip.Attestation state.
  • Creates a SubnetInfo for storing subnet attestations.
  • Adds metrics for the db calls.

Closes #1135

@avilagaston9 avilagaston9 marked this pull request as ready for review June 11, 2024 00:08
@avilagaston9 avilagaston9 requested a review from a team as a code owner June 11, 2024 00:08
Arkenan
Arkenan requested changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@Arkenan Arkenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Gastón! Added some comments.

lib/types/subnet_info.ex Outdated Show resolved Hide resolved
lib/types/subnet_info.ex Outdated Show resolved Hide resolved
lib/lambda_ethereum_consensus/telemetry.ex Outdated Show resolved Hide resolved
lib/lambda_ethereum_consensus/p2p/gossip/attestation.ex Outdated Show resolved Hide resolved
lib/lambda_ethereum_consensus/p2p/gossip/attestation.ex Outdated Show resolved Hide resolved
test/unit/attestation.exs Outdated Show resolved Hide resolved
lib/types/subnet_info.ex Outdated Show resolved Hide resolved
@avilagaston9 avilagaston9 mentioned this pull request Jun 11, 2024
Open
Arkenan
Arkenan approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@Arkenan Arkenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome PR

@Arkenan Arkenan merged commit 1ec0106 into main Jun 14, 2024
19 checks passed
@Arkenan Arkenan deleted the refactor-attestation branch June 14, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkenan Arkenan Arkenan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Lambda Ethereum Consensus Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Gossip Attestation Refactor] Replace state with db
2 participants
@avilagaston9 @Arkenan