Skip to content

Commit

Permalink
Added issue to TODO comment
Browse files Browse the repository at this point in the history
  • Loading branch information
rodrigo-o committed Jan 24, 2025
1 parent 55b4cc7 commit a15e004
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/beacon_api/event_pubsub.ex
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ defmodule BeaconApi.EventPubSub do
@moduledoc """
Event listener for aggregating and sending events for SSE subscribers.
TODO: This depends on `event_bus` and `sse`, but it could be easily switched later:
TODO: (#1368) This depends on `event_bus` and `sse`, but it could be easily switched later:
- `event_bus` we could move to phoenix pubsub
- `sse` we could just implement it ourselves using Plug.Conn.chunk and Plug.Conn.send_chunked
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ defmodule LambdaEthereumConsensus.MixProject do
{:prom_ex, "~> 1.11.0"},
{:flama, git: "https://github.com/lambdaclass/ht1223_tracer"},
{:uuid, "~> 1.1"},
# TODO: We might want to use phoenix_pubsub instead and do our implementation of SSE.
# TODO: (#1368) We might want to use phoenix_pubsub instead and do our implementation of SSE.
{:sse, "~> 0.4"},
{:event_bus, ">= 1.6.0"}
]
Expand Down

0 comments on commit a15e004

Please sign in to comment.