fix: warnings

lambdaclass · Jun 10, 2024 · 1a25c16 · 1a25c16
1 parent b3ae855
commit 1a25c16
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/lib/lambda_ethereum_consensus/p2p/gossip/attestation.ex b/lib/lambda_ethereum_consensus/p2p/gossip/attestation.ex
@@ -151,7 +151,6 @@ defmodule LambdaEthereumConsensus.P2P.Gossip.Attestation do
     id_with_trailer |> String.trim_trailing("/ssz_snappy") |> String.to_integer()
   end
 
-  @spec persist_subnet_info(SubnetInfo.t(), non_neg_integer()) :: :ok
   defp persist_subnet_info(subnet_info, subnet_id) do
     :telemetry.span([:subnet, :persist], %{}, fn ->
       {Db.put(

diff --git a/lib/types/subnet_info.ex b/lib/types/subnet_info.ex
@@ -15,12 +15,10 @@ defmodule Types.SubnetInfo do
           attestations: Attestation
         }
 
-  @spec new_subnet_with_attestation(Attestation.t()) :: t()
-  def new_subnet_with_attestation(attestation) do
-    %SubnetInfo{data: attestation.data, attestations: [attestation]}
-  end
+  def new_subnet_with_attestation(%Attestation{data: data} = attestation),
+    do: %SubnetInfo{data: data, attestations: [attestation]}
 
-  @spec aggregate_attestation(t(), Attestation.t()) :: t()
+  @spec aggregate_attestation(SubnetInfo.t(), Attestation.t()) :: SubnetInfo.t()
   def aggregate_attestation(subnet_info, attestation) do
     if subnet_info.data == attestation.data do
       %SubnetInfo{subnet_info | attestations: [attestation | subnet_info.attestations]}
@@ -29,12 +27,12 @@ defmodule Types.SubnetInfo do
     end
   end
 
-  @spec encode(t()) :: binary()
+  @spec encode(SubnetInfo.t()) :: binary()
   def encode(%__MODULE__{} = subnet_info) do
     {subnet_info.data, subnet_info.attestations} |> :erlang.term_to_binary()
   end
 
-  @spec decode(binary()) :: t()
+  @spec decode(binary()) :: SubnetInfo.t()
   def decode(bin) do
     {data, attestations} = :erlang.binary_to_term(bin)
     %__MODULE__{data: data, attestations: attestations}