remove pendulum #492
remove pendulum #492
Conversation
deronnax
force-pushed
the
drop-pendulum
branch
6 times, most recently
from
966fc3d to
07e43db
Compare
|
it looks |
| for unit, minimum in self.when_lower_than.items(): | ||
| if current <= minimum: | ||
| if self.future_time: | ||
| dt = now.add(**{f"{unit}s": current}) | ||
| dt = now + relativedelta(**{f"{unit}s": current}) |
There was a problem hiding this comment.
Is it possible we can use builtin timedelta?
from datetime import tiemdelta
dt = now + timedelta(**{f"{unit}s": current})
There was a problem hiding this comment.
That what I went with first, but timedelta doesn't handle month or year units, so I went with python-dateutils.
|
We can't simply remove python-dateutil (but it's not an addition: it was already used underneath by pendulum). Iredis would not be able to do good future/past completion in time without it, thanks to its superior |
|
Thank you so so much! |
|
Released v1.15.0 |
|
You're welcome. Thank you :) |
As it is a pain: pendulum 2 is incompatible with python 3.12 and pendulum 3 has strange build errors we do not understand. The package has governance problems were the sole maintainer won't address problems, and more problematically, won't even answer to questions, see python-pendulum/pendulum#771.
Python-dateutil is a more reliable package to rely on: it's been around for longer, is not a one-person project and the founder is now a python core-maintainer in charge of the datetime module.