Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add filter and order parameters to group relay API #2863

Merged
merged 8 commits into from
Oct 17, 2024
Merged

feat: Add filter and order parameters to group relay API #2863

merged 8 commits into from
Oct 17, 2024
+57 −9

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Sep 25, 2024 •
edited by github-actions bot
Loading 

query GroupsQuery {
    group_nodes(
        filter: "name like \"def%\"",
        ) {
            edges {
                node {
                    id
                    name
                    domain_name
                }
            }
    }
}

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

📚 Documentation preview 📚: https://sorna--2863.org.readthedocs.build/en/2863/

📚 Documentation preview 📚: https://sorna-ko--2863.org.readthedocs.build/ko/2863/

@fregataa fregataa added this to the 24.09 milestone Sep 25, 2024
@fregataa fregataa self-assigned this Sep 25, 2024
@github-actions github-actions bot added area:docs Documentations comp:manager Related to Manager component size:M 30~100 LoC labels Sep 25, 2024
@fregataa fregataa marked this pull request as ready for review September 26, 2024 05:05
agatha197
agatha197 requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fregataa The id is graphql global id. Can you add row_id too?

agatha197
agatha197 requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts

@fregataa fregataa added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 0b506fa Oct 17, 2024
23 checks passed
@fregataa fregataa deleted the feat/add-filter-and-order-params-to-group-relay-resolver branch October 17, 2024 10:14
fregataa added a commit that referenced this pull request Oct 17, 2024
@fregataa
feat: Add filter and order parameters to group relay API (#2863)
b9801fd 
Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 2863
@fregataa fregataa mentioned this pull request Oct 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 17, 2024
@fregataa
feat: Add filter and order parameters to group relay API (#2863) (#2919)
6a71848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatha197 agatha197 Awaiting requested review from agatha197

Assignees

@fregataa fregataa

Labels
area:docs Documentations comp:manager Related to Manager component size:M 30~100 LoC
Projects
None yet
Milestone
24.09
Development

Successfully merging this pull request may close these issues.
2 participants
@fregataa @agatha197