Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce models.health module that treats manager status #2565

Merged

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Jul 25, 2024

Main usage of ai.backend.manager.models.health module is treating manager status.
It has functions related to DB connection status for now.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

Copy link
Member Author

fregataa commented Jul 25, 2024

@github-actions github-actions bot added comp:manager Related to Manager component size:L 100~500 LoC labels Jul 25, 2024
@fregataa fregataa force-pushed the topic/07-25-feat_introduce_manager_db_connection_stat_api branch 2 times, most recently from 8608ce7 to c77bef5 Compare July 26, 2024 07:28
@fregataa fregataa added this to the 24.03 milestone Jul 26, 2024
@fregataa fregataa added the skip:changelog Make the action workflow to skip towncrier check label Jul 26, 2024
@fregataa fregataa marked this pull request as ready for review July 26, 2024 08:10
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... I think it would be better to rename it models.health for clarity.

@fregataa fregataa force-pushed the topic/07-25-feat_introduce_manager_db_connection_stat_api branch from c77bef5 to 68a0b22 Compare July 26, 2024 12:26
@fregataa fregataa changed the title feat: Introduce models.manager module that treats manager status feat: Introduce models.health module that treats manager status Jul 26, 2024
@fregataa fregataa requested a review from achimnol July 26, 2024 12:36
@fregataa fregataa force-pushed the topic/07-25-feat_introduce_manager_db_connection_stat_api branch 2 times, most recently from 6053eba to 4c1854b Compare August 2, 2024 06:39
@fregataa fregataa force-pushed the topic/07-25-feat_introduce_manager_db_connection_stat_api branch 3 times, most recently from 1949bfa to a27fb97 Compare August 11, 2024 06:59
@fregataa fregataa force-pushed the topic/07-25-feat_introduce_manager_db_connection_stat_api branch from a27fb97 to 6e46285 Compare August 11, 2024 10:08
@fregataa fregataa force-pushed the topic/07-25-feat_introduce_manager_db_connection_stat_api branch from 6e46285 to 78a497c Compare September 12, 2024 07:40
@fregataa fregataa force-pushed the topic/07-25-feat_introduce_manager_db_connection_stat_api branch from 78a497c to c5702e0 Compare October 15, 2024 08:08
@fregataa fregataa changed the base branch from main to topic/09-12-chore_add_metric_format_type_for_prometheus October 15, 2024 08:08
@achimnol achimnol modified the milestones: 24.03, 24.12 Oct 15, 2024
@fregataa fregataa force-pushed the topic/09-12-chore_add_metric_format_type_for_prometheus branch from 5e6c77b to 263da15 Compare October 15, 2024 10:25
Base automatically changed from topic/09-12-chore_add_metric_format_type_for_prometheus to main October 15, 2024 10:51
@fregataa fregataa force-pushed the topic/07-25-feat_introduce_manager_db_connection_stat_api branch from c5702e0 to 4de60e8 Compare October 17, 2024 08:07
@fregataa fregataa added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 6beab12 Oct 17, 2024
24 checks passed
@fregataa fregataa deleted the topic/07-25-feat_introduce_manager_db_connection_stat_api branch October 17, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:L 100~500 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants