Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance anonymous ratelimiting with dynamic thresholds and max size configuration #2086

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Apr 30, 2024

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

📚 Documentation preview 📚: https://sorna--2086.org.readthedocs.build/en/2086/


📚 Documentation preview 📚: https://sorna-ko--2086.org.readthedocs.build/ko/2086/

Copy link

graphite-app bot commented Apr 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Member Author

jopemachine commented Apr 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jopemachine and the rest of your teammates on Graphite Graphite

@jopemachine jopemachine deleted the 04-30-Enhance-anonymous-ratelimiting-with-dynamic-thresholds-and-maxsize-configuration branch April 30, 2024 02:41
@jopemachine jopemachine restored the 04-30-Enhance-anonymous-ratelimiting-with-dynamic-thresholds-and-maxsize-configuration branch April 30, 2024 03:07
@jopemachine jopemachine reopened this Apr 30, 2024
@jopemachine jopemachine changed the base branch from 04-29-feat_truncate_suspicious_ips_when_it_exceed_the_max_size to main April 30, 2024 03:13
@jopemachine
Copy link
Member Author

Closing this PR as prefering another PR.

@Yaminyam Yaminyam deleted the 04-30-Enhance-anonymous-ratelimiting-with-dynamic-thresholds-and-maxsize-configuration branch July 17, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:manager Related to Manager component size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant