Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Truncate hot_clients_ips when it exceed the max_size #2083

Open
wants to merge 3 commits into
base: 04-26-feat_implement_get_hot_anonymous_clients_to_ratelimit_api
Choose a base branch
from

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Apr 29, 2024

To prevent the hot_clients_ips set in the _rlim_script from growing indefinitely, introduce max_size.


Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

📚 Documentation preview 📚: https://sorna--2083.org.readthedocs.build/en/2083/


📚 Documentation preview 📚: https://sorna-ko--2083.org.readthedocs.build/ko/2083/

Copy link

graphite-app bot commented Apr 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Member Author

jopemachine commented Apr 29, 2024

@jopemachine jopemachine marked this pull request as ready for review April 29, 2024 02:43
@jopemachine jopemachine changed the title feat: truncate suspicious_ips when it exceed the max_size feat: truncate suspicious_ips when it exceed the max_size Apr 29, 2024
@jopemachine jopemachine linked an issue Apr 29, 2024 that may be closed by this pull request
@jopemachine jopemachine added this to the 24.09 milestone Apr 29, 2024
@github-actions github-actions bot added comp:manager Related to Manager component type:feature Add new features area:docs Documentations size:XS ~10 LoC size:M 30~100 LoC and removed size:XS ~10 LoC labels Apr 29, 2024
@jopemachine jopemachine force-pushed the 04-26-feat_implement_get_hot_anonymous_clients_to_ratelimit_api branch from 5279a24 to 1773971 Compare April 30, 2024 02:12
@jopemachine jopemachine force-pushed the 04-29-feat_truncate_suspicious_ips_when_it_exceed_the_max_size branch 2 times, most recently from 76fad94 to 826f01b Compare April 30, 2024 02:13
@github-actions github-actions bot added size:XS ~10 LoC and removed size:M 30~100 LoC labels Apr 30, 2024
@jopemachine jopemachine force-pushed the 04-26-feat_implement_get_hot_anonymous_clients_to_ratelimit_api branch from 1773971 to 0d950f3 Compare April 30, 2024 04:29
@jopemachine jopemachine force-pushed the 04-29-feat_truncate_suspicious_ips_when_it_exceed_the_max_size branch from 826f01b to d075b8e Compare April 30, 2024 04:29
@github-actions github-actions bot added size:S 10~30 LoC and removed size:XS ~10 LoC labels Apr 30, 2024
@jopemachine jopemachine changed the title feat: truncate suspicious_ips when it exceed the max_size feat: truncate hot_clients_ips when it exceed the max_size Apr 30, 2024
@jopemachine jopemachine changed the title feat: truncate hot_clients_ips when it exceed the max_size feat: Truncate hot_clients_ips when it exceed the max_size Apr 30, 2024
@jopemachine jopemachine force-pushed the 04-26-feat_implement_get_hot_anonymous_clients_to_ratelimit_api branch from a032db3 to 91f5600 Compare August 5, 2024 04:51
@jopemachine jopemachine force-pushed the 04-29-feat_truncate_suspicious_ips_when_it_exceed_the_max_size branch from 646aefb to fe5dfef Compare August 5, 2024 04:51
@jopemachine jopemachine force-pushed the 04-26-feat_implement_get_hot_anonymous_clients_to_ratelimit_api branch from 91f5600 to d11c050 Compare September 30, 2024 13:51
@jopemachine jopemachine force-pushed the 04-29-feat_truncate_suspicious_ips_when_it_exceed_the_max_size branch from fe5dfef to 21403c5 Compare September 30, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:manager Related to Manager component size:S 10~30 LoC type:feature Add new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DDoS prevention for anonymous manager API requests
1 participant