Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move anonymous_ratelimit to shared_config #2067

Open
wants to merge 4 commits into
base: 04-25-DDoS_prevention_for_anonymous_manager_API_requests
Choose a base branch
from

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Apr 25, 2024

Change the location of the anonymous_ratelimit settings to etcd (local_config -> shared_config).

Command test

For example, to set the anonymous_ratelimit value to 10, execute the following command.

./backend.ai mgr etcd put config/anonymous_ratelimit 10

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

📚 Documentation preview 📚: https://sorna--2067.org.readthedocs.build/en/2067/


📚 Documentation preview 📚: https://sorna-ko--2067.org.readthedocs.build/ko/2067/

Copy link
Member Author

jopemachine commented Apr 25, 2024

@github-actions github-actions bot added area:docs Documentations comp:manager Related to Manager component size:XS ~10 LoC labels Apr 25, 2024
@jopemachine jopemachine changed the title Move anonymous_ratelimit to shared_config refactor: Move anonymous_ratelimit to shared_config Apr 25, 2024
@jopemachine jopemachine marked this pull request as ready for review April 25, 2024 07:51
@jopemachine jopemachine added this to the 24.09 milestone Apr 25, 2024
@jopemachine jopemachine linked an issue Apr 25, 2024 that may be closed by this pull request
@github-actions github-actions bot added the type:feature Add new features label Apr 25, 2024
@jopemachine jopemachine force-pushed the 04-25-move_anonymous_ratelimit_to_shared_config branch from 11c436d to cff9ca4 Compare April 26, 2024 07:01
@jopemachine jopemachine changed the base branch from feat/prevent-ddos to 04-25-DDoS_prevention_for_anonymous_manager_API_requests April 26, 2024 07:01
@jopemachine jopemachine force-pushed the 04-25-DDoS_prevention_for_anonymous_manager_API_requests branch 2 times, most recently from e0445f9 to ef09838 Compare April 26, 2024 07:49
@jopemachine jopemachine force-pushed the 04-25-move_anonymous_ratelimit_to_shared_config branch from 72e5315 to 6db5684 Compare April 26, 2024 07:49
@jopemachine jopemachine force-pushed the 04-25-DDoS_prevention_for_anonymous_manager_API_requests branch from ef09838 to b6c4ce6 Compare April 29, 2024 02:42
@jopemachine jopemachine force-pushed the 04-25-move_anonymous_ratelimit_to_shared_config branch from 6db5684 to 96e3580 Compare April 29, 2024 02:43
@jopemachine jopemachine force-pushed the 04-25-DDoS_prevention_for_anonymous_manager_API_requests branch from b6c4ce6 to b54cbe6 Compare April 30, 2024 02:12
@jopemachine jopemachine force-pushed the 04-25-move_anonymous_ratelimit_to_shared_config branch from 96e3580 to cc47a98 Compare April 30, 2024 02:12
@jopemachine jopemachine force-pushed the 04-25-DDoS_prevention_for_anonymous_manager_API_requests branch from b54cbe6 to 637d4e2 Compare August 5, 2024 04:50
@jopemachine jopemachine force-pushed the 04-25-move_anonymous_ratelimit_to_shared_config branch from cc47a98 to 93f6b02 Compare August 5, 2024 04:50
@jopemachine jopemachine force-pushed the 04-25-DDoS_prevention_for_anonymous_manager_API_requests branch from 637d4e2 to 5702f31 Compare September 30, 2024 13:29
@jopemachine jopemachine force-pushed the 04-25-move_anonymous_ratelimit_to_shared_config branch from 93f6b02 to 8a127d8 Compare September 30, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:manager Related to Manager component size:XS ~10 LoC type:feature Add new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DDoS prevention for anonymous manager API requests
1 participant