chore: Add override annotations to RBAC methods (#2891)

lablup · Oct 7, 2024 · d909a3e · d909a3e
1 parent a322178
commit d909a3e
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 0 deletions.
diff --git a/src/ai/backend/manager/models/agent.py b/src/ai/backend/manager/models/agent.py
@@ -832,6 +832,7 @@ async def calculate_permission(
         permissions = await self._calculate_permission_by_predefined_roles(roles)
         return permissions
 
+    @override
     async def build_ctx_in_system_scope(
         self,
         ctx: ClientContext,
@@ -845,6 +846,7 @@ async def build_ctx_in_system_scope(
             perm_ctx.merge(to_be_merged)
         return perm_ctx
 
+    @override
     async def build_ctx_in_domain_scope(
         self,
         ctx: ClientContext,
@@ -870,6 +872,7 @@ async def build_ctx_in_domain_scope(
                 aid_permission_map[ag.id] = permissions
         return AgentPermissionContext(object_id_to_additional_permission_map=aid_permission_map)
 
+    @override
     async def build_ctx_in_project_scope(
         self,
         ctx: ClientContext,
@@ -895,6 +898,7 @@ async def build_ctx_in_project_scope(
                 aid_permission_map[ag.id] = permissions
         return AgentPermissionContext(object_id_to_additional_permission_map=aid_permission_map)
 
+    @override
     async def build_ctx_in_user_scope(
         self,
         ctx: ClientContext,
@@ -928,30 +932,35 @@ async def build_ctx_in_user_scope(
                 aid_permission_map[ag.id] = permissions
         return AgentPermissionContext(object_id_to_additional_permission_map=aid_permission_map)
 
+    @override
     @classmethod
     async def _permission_for_owner(
         cls,
     ) -> frozenset[AgentPermission]:
         return OWNER_PERMISSIONS
 
+    @override
     @classmethod
     async def _permission_for_admin(
         cls,
     ) -> frozenset[AgentPermission]:
         return ADMIN_PERMISSIONS
 
+    @override
     @classmethod
     async def _permission_for_monitor(
         cls,
     ) -> frozenset[AgentPermission]:
         return MONITOR_PERMISSIONS
 
+    @override
     @classmethod
     async def _permission_for_privileged_member(
         cls,
     ) -> frozenset[AgentPermission]:
         return PRIVILEGED_MEMBER_PERMISSIONS
 
+    @override
     @classmethod
     async def _permission_for_member(
         cls,

diff --git a/src/ai/backend/manager/models/session.py b/src/ai/backend/manager/models/session.py
@@ -2005,6 +2005,7 @@ async def calculate_permission(
         permissions = await self._calculate_permission_by_predefined_roles(roles)
         return permissions
 
+    @override
     async def build_ctx_in_system_scope(
         self,
         ctx: ClientContext,
@@ -2018,6 +2019,7 @@ async def build_ctx_in_system_scope(
             perm_ctx.merge(to_be_merged)
         return perm_ctx
 
+    @override
     async def build_ctx_in_domain_scope(
         self,
         ctx: ClientContext,
@@ -2032,6 +2034,7 @@ async def build_ctx_in_domain_scope(
         permission_ctx.merge(_project_perm_ctx)
         return permission_ctx
 
+    @override
     async def build_ctx_in_project_scope(
         self,
         ctx: ClientContext,
@@ -2042,6 +2045,7 @@ async def build_ctx_in_project_scope(
         permission_ctx.merge(_user_perm_ctx)
         return permission_ctx
 
+    @override
     async def build_ctx_in_user_scope(
         self,
         ctx: ClientContext,
@@ -2120,30 +2124,35 @@ async def _build_at_user_scope_non_recursively(
         result = ComputeSessionPermissionContext(user_id_to_permission_map={user_id: permissions})
         return result
 
+    @override
     @classmethod
     async def _permission_for_owner(
         cls,
     ) -> frozenset[ComputeSessionPermission]:
         return OWNER_PERMISSIONS
 
+    @override
     @classmethod
     async def _permission_for_admin(
         cls,
     ) -> frozenset[ComputeSessionPermission]:
         return ADMIN_PERMISSIONS
 
+    @override
     @classmethod
     async def _permission_for_monitor(
         cls,
     ) -> frozenset[ComputeSessionPermission]:
         return MONITOR_PERMISSIONS
 
+    @override
     @classmethod
     async def _permission_for_privileged_member(
         cls,
     ) -> frozenset[ComputeSessionPermission]:
         return PRIVILEGED_MEMBER_PERMISSIONS
 
+    @override
     @classmethod
     async def _permission_for_member(
         cls,

diff --git a/src/ai/backend/manager/models/storage.py b/src/ai/backend/manager/models/storage.py
@@ -452,6 +452,7 @@ async def calculate_permission(
         permissions = await self._calculate_permission_by_predefined_roles(roles)
         return permissions
 
+    @override
     async def build_ctx_in_system_scope(
         self,
         ctx: ClientContext,
@@ -465,6 +466,7 @@ async def build_ctx_in_system_scope(
             perm_ctx.merge(to_be_merged)
         return perm_ctx
 
+    @override
     async def build_ctx_in_domain_scope(
         self,
         ctx: ClientContext,
@@ -493,6 +495,7 @@ async def build_ctx_in_domain_scope(
         )
         return result
 
+    @override
     async def build_ctx_in_project_scope(
         self,
         ctx: ClientContext,
@@ -522,6 +525,7 @@ async def build_ctx_in_project_scope(
         )
         return result
 
+    @override
     async def build_ctx_in_user_scope(
         self,
         ctx: ClientContext,
@@ -567,30 +571,35 @@ async def build_ctx_in_user_scope(
         )
         return result
 
+    @override
     @classmethod
     async def _permission_for_owner(
         cls,
     ) -> frozenset[StorageHostPermission]:
         return OWNER_PERMISSIONS
 
+    @override
     @classmethod
     async def _permission_for_admin(
         cls,
     ) -> frozenset[StorageHostPermission]:
         return ADMIN_PERMISSIONS
 
+    @override
     @classmethod
     async def _permission_for_monitor(
         cls,
     ) -> frozenset[StorageHostPermission]:
         return MONITOR_PERMISSIONS
 
+    @override
     @classmethod
     async def _permission_for_privileged_member(
         cls,
     ) -> frozenset[StorageHostPermission]:
         return PRIVILEGED_MEMBER_PERMISSIONS
 
+    @override
     @classmethod
     async def _permission_for_member(
         cls,

diff --git a/src/ai/backend/manager/models/vfolder.py b/src/ai/backend/manager/models/vfolder.py
@@ -2321,6 +2321,7 @@ async def calculate_permission(
         permissions = await self._calculate_permission_by_predefined_roles(roles)
         return permissions
 
+    @override
     async def build_ctx_in_system_scope(
         self,
         ctx: ClientContext,
@@ -2334,6 +2335,7 @@ async def build_ctx_in_system_scope(
             perm_ctx.merge(to_be_merged)
         return perm_ctx
 
+    @override
     async def build_ctx_in_domain_scope(
         self,
         ctx: ClientContext,
@@ -2348,6 +2350,7 @@ async def build_ctx_in_domain_scope(
         permission_ctx.merge(_project_perm_ctx)
         return permission_ctx
 
+    @override
     async def build_ctx_in_project_scope(
         self, ctx: ClientContext, scope: ProjectScope
     ) -> VFolderPermissionContext:
@@ -2356,6 +2359,7 @@ async def build_ctx_in_project_scope(
         permission_ctx.merge(_user_perm_ctx)
         return permission_ctx
 
+    @override
     async def build_ctx_in_user_scope(
         self, ctx: ClientContext, scope: UserRBACScope
     ) -> VFolderPermissionContext:
@@ -2492,30 +2496,35 @@ async def _build_at_user_scope_non_recursively(
             result.object_id_to_overriding_permission_map = object_id_to_permission_map
         return result
 
+    @override
     @classmethod
     async def _permission_for_owner(
         cls,
     ) -> frozenset[VFolderRBACPermission]:
         return OWNER_PERMISSIONS
 
+    @override
     @classmethod
     async def _permission_for_admin(
         cls,
     ) -> frozenset[VFolderRBACPermission]:
         return ADMIN_PERMISSIONS
 
+    @override
     @classmethod
     async def _permission_for_monitor(
         cls,
     ) -> frozenset[VFolderRBACPermission]:
         return MONITOR_PERMISSIONS
 
+    @override
     @classmethod
     async def _permission_for_privileged_member(
         cls,
     ) -> frozenset[VFolderRBACPermission]:
         return PRIVILEGED_MEMBER_PERMISSIONS
 
+    @override
     @classmethod
     async def _permission_for_member(
         cls,