Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch - tab refresh, flow order #921

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

supraja-968
Copy link
Collaborator

What type of PR is this?

  • 🐛 Bug Fix

Description

2 bugs fixed with this PR:
1. active tab getting reset to the default (metrics if available / logs) every 5 second with the refresh logic
2. experiments ordered in ascending order of start_time within each time category

Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 2:14pm

Copy link
Contributor

@acashmoney acashmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@supraja-968 I updated the active tab useEffect hook to pass in activeTab which was previously causing a build error.

I also modified the if statement to properly toggle the active tab. Now, the activeTab will be set to "metrics" if checkpointCompatible is true and the current activeTab is an empty string. Otherwise, it will be set to "logs" only when the activeTab is an empty string.

@supraja-968
Copy link
Collaborator Author

@supraja-968 I updated the active tab useEffect hook to pass in activeTab which was previously causing a build error.

I also modified the if statement to properly toggle the active tab. Now, the activeTab will be set to "metrics" if checkpointCompatible is true and the current activeTab is an empty string. Otherwise, it will be set to "logs" only when the activeTab is an empty string.

sounds good!

@supraja-968 supraja-968 merged commit 9e04b24 into main Mar 18, 2024
16 checks passed
@supraja-968 supraja-968 deleted the patch_tab_refresh_exp_order branch March 18, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants