General clean-up, especially around docs, in preparation for v1.0 #386
Conversation
|
Fixed a couple of papercut bugs, and revamped the docs appearance. @Luthaf - IDK what you had in mind in terms of docs restructuring, overall it doesn't look bad to me as it is now. |
|
OK I tried also to look into the symbol bugs that @bernstei pointed at, but it looks like it's not a trivial fix so probably deserving of a separate PR. Time to merge this before it becomes an everything-pr! |
|
Thanks a lot for the clean up and update of the doc style! :) I pushed a commit to fix a warning |
Thanks - we actually removed this setting in a previous PR as it was pretty useless and complicating a lot the logic around size scaling. This error should actually be also already fixed as I modified the example .json - if you still get the error locally you probably need to clear your examples cache so they get downloaded again. |
| // loads a random example | ||
| var exampleKeys = Object.keys(examples); | ||
| var randomIndex = Math.floor(Math.random() * exampleKeys.length); | ||
| var randomExampleKey = exampleKeys[randomIndex]; | ||
|
|
||
| await app.loadExample(randomExampleKey); |
There was a problem hiding this comment.
I'm worried this might make loading the website slower, since some of the examples add a fairly large download. Zeolites.json.gz is 1.8MiB, and CSD-1000R.json.gz is 3.5 MiB
There was a problem hiding this comment.
True, but chemiscope.min.js is 3MB already so even in the worst case it will make loading 2x slower....
Maybe we can test a bit and see if it's a problem, and in case I think the "right thing" would be to reduce a bit the size of the demo datasets.
Tweaked icon, switch to furo, custom colors
When shapes got selected, it was not possible to go back to a visualization without shapes by just crtl-clicking all entries in the shape list. Had do move around some stuff making the code a bit less transparent.
Mildly customized furo theme looks much better IMO