Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[todo] TabsViewController finish scroll implementation #15

Open
kyzmitch opened this issue Aug 20, 2021 · 0 comments
Open

[todo] TabsViewController finish scroll implementation #15

kyzmitch opened this issue Aug 20, 2021 · 0 comments
Labels
todo todo from source code

Comments

@kyzmitch
Copy link
Owner

Cotton/catowser/catowser/WebTabs/TabsViewController.swift

Line 299 in 8f3cede

// pixels could be negative to scroll to the left

Cotton/catowser/catowser/WebTabs/TabsViewController.swift

Line 157 in 8f3cede

// TODO: finish impl below

When new tab is added (usually at the end of the list - right side) user could have tab selected in the beginning of the list and there are a lot of other tabs, so, we're scrolling tab views to show the last one which was added/selected automatically. This works, but it seems need to finish some corner cases.
@kyzmitch kyzmitch changed the title TabsViewController finish scroll implementation [todo] TabsViewController finish scroll implementation Aug 20, 2021
@kyzmitch kyzmitch added the todo todo from source code label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
todo todo from source code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kyzmitch