[todo] Combine cMakeRequest needs to be cancellable #14
Labels
todo
todo from source code
Comments
kyzmitch
changed the title
kyzmitch
added a commit
that referenced
this issue
Dec 13, 2024
* Concurrently fetch use cases if possible * Rename of actor based interface and add another one for class based * Inject search bar view model (need to fix one compile error) * Fix compilation * Make tabs data service internal to the module * Add base class for data service * New files * Add dispatch queues and promise table * Add initial search data service code * Register data service in locator * Make start/init of phone tab previews coordinator sync again to fix use case registration race * Add app assembler * Move remaining app start data to app assembler * Renaming * Add a note about #14 * Re-indent params * Implement functions in search data service and move some files * Remove dependency on specific strategies to be able to switch between them in runtime * Properly register auto search suggestions use case * Better use case func names * Domain resolving use case changes to use new data service * Adapt search suggestions view model to the new use case and data service * Adapt rx swift use case functions * One more command in Search data service * Dependencies for view model factory * Re-indent params * Merge async service registry class with service registry * Fix tabs data service registration, because it has an associated type * Fix app coordinator crash * Use abstract protocol for the search data service to hide the implementation * Renamed a bunch of frameworks and added view models and data services frameworks. Still there a two sendable errors. * Fix several errors * Fix imports in use cases module * Fix several errors in main build target by importing new modules * Fix not trivial problem with module verification by adding -no-verify-emitted-module-interface option to Other Swift Flags for several new modules * Fix build * Remove extra imports * Add doc comments * Minor changes * Rename Rest client functions * Not finished work about service data in tabs service * Not finished work about service data in tabs service - part #2 * Not finished work about service data in tabs service - part #3 (fixed compilation) * Add errors propagation to some use cases * small performance optimisation for the initial tabs loading * Return new selected tab if closed tab was selected * Remove CottonData module and move remaining files to CoreBrowser * new bundle ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Cotton/catowser/HttpKit/HttpClient+Combine.swift
Line 65 in 7ffc5c7
Wasn't able to find how to handle task cancellation for Combine Publishers. This is needed for HttpKit code to finish implementation.
The only way to cancel the Publisher is to have AnyCancellable object which can be retrieved from
sinkorassingfunctions which start the publisher right away and this is not desired.The text was updated successfully, but these errors were encountered: