-
Notifications
You must be signed in to change notification settings - Fork 29
v2alpha1 as stored version #1777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kubicar
wants to merge
12
commits into
kyma-project:main
Choose a base branch
from
kubicar:api-gateway-1727
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,741
−4,013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97b8453
to
92b4172
Compare
0593b1f
to
69bde8e
Compare
69bde8e
to
bd8833c
Compare
bd8833c
to
6cfc6ed
Compare
14 tasks
1c04784
to
dec446d
Compare
2abb75a
to
c553779
Compare
d00fbca
to
e441330
Compare
…issing on optional parameter annotation
…aders and cookies
barchw
reviewed
Apr 23, 2025
Tested migration: v1beta1 -> v2alpha1 -> v2 with success |
barchw
reviewed
Apr 28, 2025
@@ -64,7 +64,7 @@ func (s *scenario) thereIsApiRuleVirtualServiceWithHttpbinServiceDestination() e | |||
|
|||
func (s *scenario) resourceOwnedByApiRuleDoesNotExist(resourceKind string) error { | |||
res := resource.GetResourceGvr(resourceKind) | |||
ownerLabelSelector := fmt.Sprintf("apirule.gateway.kyma-project.io/v1beta1=%s-%s.%s", s.name, s.TestID, s.Namespace) | |||
ownerLabelSelector := fmt.Sprintf("apirule.gateway.kyma-project.io/v2alpha1=%s-%s.%s", s.name, s.TestID, s.Namespace) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was the ownerlabel switched here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
This PR implements a complete conversion and mutating webhook system for APIRule resources
across multiple API versions (v1beta1, v2alpha1, v2) with v2alpha1 as the hub version.
Key changes:
Pre-Merge Checklist
Related issues