test: spec should be empty for not convertible AR

Author: kubicar

apis/gateway/v1beta1/apirule_conversion_test.go

@@ -359,7 +359,7 @@ var _ = Describe("APIRule Conversion", func() {
 
 		})
 
-		It("should store rules in annotation", func() {
+		It("should store spec in annotation", func() {
 			var headerConfig, cookieConfig runtime.RawExtension
 			_ = convertOverJson(map[string]string{
 				"header1": "value1",
@@ -369,9 +369,19 @@ var _ = Describe("APIRule Conversion", func() {
 				"cookie1": "value2",
 			}, &cookieConfig)
 
+			namespace := "test-namespace"
+			var port uint32 = 8080
+
 			apiRuleV1beta1 := v1beta1.APIRule{
 				Status: testV1StatusOK,
 				Spec: v1beta1.APIRuleSpec{
+					Host:    &host1string,
+					Gateway: ptr.To("gateway-test"),
+					Service: &v1beta1.Service{
+						Name:      ptr.To("service-test"),
+						Port:      &port,
+						Namespace: &namespace,
+					},
 					Rules: []v1beta1.Rule{
 						{
 							Path: "/path1",
@@ -407,7 +417,7 @@ var _ = Describe("APIRule Conversion", func() {
 
 			// then
 			Expect(err).ToNot(HaveOccurred())
-			Expect(apiRuleV2alpha1.Annotations["gateway.kyma-project.io/v1beta1-rules"]).To(BeEquivalentTo(`[{"path":"/path1","service":{"name":"service","port":null},"methods":["GET","POST"],"accessStrategies":[{"handler":"jwt"}],"mutators":[{"handler":"header","config":{"header1":"value1"}},{"handler":"cookie","config":{"cookie1":"value2"}}]}]`))
+			Expect(apiRuleV2alpha1.Annotations["gateway.kyma-project.io/v1beta1-spec"]).To(BeEquivalentTo(`{"host":"host1","service":{"name":"service-test","namespace":"test-namespace","port":8080},"gateway":"gateway-test","rules":[{"path":"/path1","service":{"name":"service","port":null},"methods":["GET","POST"],"accessStrategies":[{"handler":"jwt"}],"mutators":[{"handler":"header","config":{"header1":"value1"}},{"handler":"cookie","config":{"cookie1":"value2"}}]}]}`))
 		})
 
 	})
@@ -808,13 +818,13 @@ var _ = Describe("APIRule Conversion", func() {
 			}
 			Expect(correctMutators).To(Equal(2))
 		})
-		It("should convert rules from annotation", func() {
+		It("should convert spec from annotation", func() {
 			// given
 			apiRuleV2alpha1 := v2alpha1.APIRule{
 				ObjectMeta: metav1.ObjectMeta{
 					Annotations: map[string]string{
 						"gateway.kyma-project.io/original-version": "v1beta1",
-						"gateway.kyma-project.io/v1beta1-rules":    `spec: [{"path":"/path1","service":{"name":"service","port":null},"methods":["GET","POST"],"accessStrategies":[{"handler":"jwt"}],"mutators":[{"handler":"header","config":{"header1":"value1"}},{"handler":"cookie","config":{"cookie1":"value2"}}]}]`,
+						"gateway.kyma-project.io/v1beta1-spec":     `{"host":"host1","service":{"name":"service-test","namespace":"test-namespace","port":8080},"gateway":"gateway-test","rules":[{"path":"/path1","service":{"name":"service","port":null},"methods":["GET","POST"],"accessStrategies":[{"handler":"jwt"}],"mutators":[{"handler":"header","config":{"header1":"value1"}},{"handler":"cookie","config":{"cookie1":"value2"}}]}]}`,
 					},
 				},
 			}
@@ -823,10 +833,18 @@ var _ = Describe("APIRule Conversion", func() {
 
 			// when
 			err := apiRuleBeta1.ConvertFrom(&apiRuleV2alpha1)
-
+			var port uint32 = 8080
 			// then
 			Expect(err).ToNot(HaveOccurred())
 			Expect(apiRuleBeta1.Spec.Rules).To(HaveLen(1))
+			Expect(apiRuleBeta1.Spec.Host).To(Equal(ptr.To(host1string)))
+			Expect(apiRuleBeta1.Spec.Service).To(Equal(ptr.To(v1beta1.Service{
+				Name:      ptr.To("service-test"),
+				Namespace: ptr.To("test-namespace"),
+				Port:      &port,
+			})))
+			Expect(*apiRuleBeta1.Spec.Gateway).To(Equal("gateway-test"))
+			Expect(apiRuleBeta1.Spec.Rules[0].Path).To(Equal("/path1"))
 		})
 	})
 })