Improverment - Statusbar background color based on theme

[AlessandroFrangiamone]

The following PR includes the functionality requested in issue #1665.

Implementation description:

I have created the methodosetBarsColourBasedOnCurrentTheme which takes the UserPreferences.Theme as input and assigns the corresponding appearance to the stasubar and navbar.
Note that the UserPreferences.Theme was passed as input so that in the Theme.System and Theme.Sunrise cases the same method can be recursively called while keeping the code clean.

Result:

Screen.Recording.2024-02-11.at.17.36.26.mp4

[kylecorry31]

I believe all of these (excluding Black and Night) can be combined under either isDarkThemeOn() and !isDarkThemeOn() (or just else). That should simplify this and avoid any potential discrepancies in sunriseSunsetTheme (it would be very rare for that to happen though).

Ex.

when {
theme == UserPreferences.Theme.Black || theme == UserPreferences.Theme.Night ->
// Same as today
}
isDarkThemeOn() -> {
window.statusBarColor = ColorUtils.backgroundColor(window.decorView.rootView.context)
}
else -> {
// Light
window.statusBarColor = ColorUtils.backgroundColor(window.decorView.rootView.context)
WindowInsetsControllerCompat(window, window.decorView).isAppearanceLightStatusBars = true
}

[AlessandroFrangiamone]

Yes, the code is simpler that way. Fixed.

[kylecorry31]

Thanks, I left one comment - if you prefer I make that change after, let me know and I'll merge as is.

[AlessandroFrangiamone]

Thanks, I left one comment - if you prefer I make that change after, let me know and I'll merge as is.

Just fixed