Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add linewise deletion of surrounds #311

Closed
wants to merge 1 commit into from

Conversation

phgz
Copy link
Contributor

@phgz phgz commented Feb 25, 2024

Skeleton implementation for #305.

Mainly missing doc and tests.

@kylechui
Copy link
Owner

One minor concern that I have is how cS will now be interpreted, i.e. does the "line" for S mean that the replacement will be on new lines (as is current), or that it will delete the lines the surround is on (as you propose)? I feel that this might not be the most intuitive.

@phgz
Copy link
Contributor Author

phgz commented Feb 26, 2024

I see. Well personally I do not directly use dS, but rather dVs (remap) as mentioned in #305. So maybe it could directly be added as such, although I'm not sure how many people are familiar with the force-motion feature.

@kylechui
Copy link
Owner

Hmm... I'm personally quite wary of adding new features nowadays; I would probably like to see a few more people say that they really want this feature before I commit to adding it in. I personally don't think most people know about force-motion; many don't even know about motion or text-object 😉

@phgz
Copy link
Contributor Author

phgz commented Feb 26, 2024

No problem! I'll maintain my fork hehe.

@phgz phgz closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants