Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be careful using this repo #1

Open
isaac-quoterite opened this issue Sep 26, 2024 · 0 comments
Open

Be careful using this repo #1

isaac-quoterite opened this issue Sep 26, 2024 · 0 comments

Comments

@isaac-quoterite
Copy link

isaac-quoterite commented Sep 26, 2024

So I've been using this repository as inspiration for translation to another language (Kotlin)...

And if you do similar - be very, very careful. There's a few hacky pieces in here that cause readability issues and typically wouldn't get past a code review, like:

  • issues with separation of concerns (the LexoRank class contains a lot of Decimal functionality), somewhat breaking Demeter's
  • unclear use of statics
  • reassigning method/function parameters
  • reassigning values in for loop declarations

Sure, some of it is the C# <> Kotlin translation, but a lot of these issues are not.

The code itself here seems to mostly work, however the range of tests here don't really stress-test the algorithm, and I suggest you do so to validate your implementation and usage...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant