Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timing in the final QueryResult for create fts/hnsw index #4915

Merged
merged 4 commits into from
Feb 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extension/fts/src/function/create_fts_index.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ std::string createFTSIndexQuery(ClientContext& context, const TableFuncBindData&
ftsBindData->createFTSConfig.stopWordsTableInfo.stopWords);
query += stringFormat("CALL _CREATE_FTS_INDEX('{}', '{}', {}, {});", tableName, indexName,
properties, params);
query += stringFormat("RETURN 'Index {} has been created.';", ftsBindData->indexName);
query += stringFormat("RETURN 'Index {} has been created.' as result;", ftsBindData->indexName);
return query;
}

Expand Down
3 changes: 2 additions & 1 deletion src/function/table/hnsw/create_hnsw_index.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ static std::string createHNSWIndexTables(main::ClientContext& context,
query += stringFormat("CALL _CREATE_HNSW_INDEX('{}', '{}', '{}', {});", hnswBindData->indexName,
hnswBindData->tableEntry->getName(),
hnswBindData->tableEntry->getProperty(hnswBindData->propertyID).getName(), params);
query += stringFormat("RETURN 'Index {} has been created.';", hnswBindData->indexName);
query +=
stringFormat("RETURN 'Index {} has been created.' as result;", hnswBindData->indexName);
if (requireNewTransaction) {
query += "COMMIT;";
}
Expand Down
3 changes: 3 additions & 0 deletions src/include/main/query_summary.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ class QuerySummary {
*/
KUZU_API double getExecutionTime() const;

void incrementCompilingTime(double increment);
void incrementExecutionTime(double increment);

void setPreparedSummary(PreparedSummary preparedSummary_);

/**
Expand Down
6 changes: 6 additions & 0 deletions src/main/client_context.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ std::unique_ptr<QueryResult> ClientContext::queryNoLock(std::string_view query,
}
std::unique_ptr<QueryResult> queryResult;
QueryResult* lastResult = nullptr;
double internalCompilingTime = 0.0, internalExecutionTime = 0.0;
for (const auto& statement : parsedStatements) {
auto preparedStatement = prepareNoLock(statement, false /*shouldCommitNewTransaction*/);
auto currentQueryResult = executeNoLock(preparedStatement.get(), queryID);
Expand All @@ -351,11 +352,16 @@ std::unique_ptr<QueryResult> ClientContext::queryNoLock(std::string_view query,
}
break;
}
auto currentQuerySummary = currentQueryResult->getQuerySummary();
if (statement->isInternal()) {
// The result of internal statements should be invisible to end users. Skip chaining the
// result of internal statements to the final result to end users.
internalCompilingTime = currentQuerySummary->getCompilingTime();
internalExecutionTime = currentQuerySummary->getExecutionTime();
continue;
}
currentQuerySummary->incrementCompilingTime(internalCompilingTime);
currentQuerySummary->incrementExecutionTime(internalExecutionTime);
if (!lastResult) {
// first result of the query
queryResult = std::move(currentQueryResult);
Expand Down
8 changes: 8 additions & 0 deletions src/main/query_summary.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,14 @@ double QuerySummary::getExecutionTime() const {
return executionTime;
}

void QuerySummary::incrementCompilingTime(double increment) {
preparedSummary.compilingTime += increment;
}

void QuerySummary::incrementExecutionTime(double increment) {
executionTime += increment;
}

void QuerySummary::setPreparedSummary(PreparedSummary preparedSummary_) {
preparedSummary = preparedSummary_;
}
Expand Down
Loading