-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timing in the final QueryResult for create fts/hnsw index #4915
Conversation
52fb0c0
to
f600738
Compare
Benchmark ResultMaster commit hash:
|
7e8c512
to
3a933ae
Compare
545d06d
to
c99c4d8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4915 +/- ##
=======================================
Coverage 86.53% 86.53%
=======================================
Files 1403 1403
Lines 60695 60706 +11
Branches 7472 7473 +1
=======================================
+ Hits 52520 52533 +13
+ Misses 8006 8004 -2
Partials 169 169 ☔ View full report in Codecov by Sentry. |
Benchmark ResultMaster commit hash:
|
Description
Create fts/hnsw index invokes the rewrite mechanism, thus a single query expands into multiple statements, but only the last statement's execution result is visible to users (others are internal and their execution results are indivisible to users unless there are errors encountered). This causes a gap between the execution/compiling time of the last statement and the actual one for the whole query.
To fix the gap, this PR collects compiling/execution time for all internal statements and aggregate them into the final query result, which is visible to users.