Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recursive extend binding #4896

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

andyfengHKU
Copy link
Contributor

Description

Remove triggering recursive join algorithms from function call and instead always ask user to use Cypher pattern matching. This should simplify our binding logic a lot. Otherwise we will have to maintain two versions of it.

@andyfengHKU andyfengHKU force-pushed the remove-recursive-extend-binding branch from e60083e to 669570e Compare February 13, 2025 07:03
Copy link

Benchmark Result

Master commit hash: b3e085f6e9914cdd8a35effd2750751616c997fa
Branch commit hash: 877309d1fd638ba97bf78f47d0cf46c8d6072374

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 725.12 724.58 0.54 (0.07%)
aggregation q28 6379.30 6338.05 41.25 (0.65%)
filter q14 128.67 127.55 1.12 (0.88%)
filter q15 129.66 124.44 5.21 (4.19%)
filter q16 307.04 306.33 0.71 (0.23%)
filter q17 444.34 471.91 -27.58 (-5.84%)
filter q18 1922.68 1969.97 -47.29 (-2.40%)
filter zonemap-node 90.16 90.10 0.07 (0.07%)
filter zonemap-node-lhs-cast 88.46 88.50 -0.04 (-0.04%)
filter zonemap-node-null 88.28 88.34 -0.06 (-0.06%)
filter zonemap-rel 5406.29 5406.63 -0.35 (-0.01%)
fixed_size_expr_evaluator q07 579.32 578.16 1.16 (0.20%)
fixed_size_expr_evaluator q08 812.47 810.95 1.52 (0.19%)
fixed_size_expr_evaluator q09 812.11 808.24 3.87 (0.48%)
fixed_size_expr_evaluator q10 243.70 243.90 -0.20 (-0.08%)
fixed_size_expr_evaluator q11 235.94 237.42 -1.48 (-0.62%)
fixed_size_expr_evaluator q12 233.86 233.81 0.05 (0.02%)
fixed_size_expr_evaluator q13 1450.57 1452.11 -1.54 (-0.11%)
fixed_size_seq_scan q23 117.46 120.82 -3.36 (-2.78%)
join q29 750.97 790.78 -39.81 (-5.03%)
join q30 11019.95 10771.95 247.99 (2.30%)
join q31 5.93 5.42 0.51 (9.40%)
join SelectiveTwoHopJoin 54.32 54.98 -0.66 (-1.20%)
ldbc_snb_ic q35 2524.54 2599.88 -75.34 (-2.90%)
ldbc_snb_ic q36 487.24 460.25 26.99 (5.86%)
ldbc_snb_is q32 5.35 4.95 0.40 (8.05%)
ldbc_snb_is q33 15.86 16.52 -0.66 (-3.99%)
ldbc_snb_is q34 1.27 1.24 0.04 (2.88%)
multi-rel multi-rel-large-scan 1290.27 1312.56 -22.29 (-1.70%)
multi-rel multi-rel-lookup 21.01 18.22 2.79 (15.32%)
multi-rel multi-rel-small-scan 76.69 87.17 -10.48 (-12.02%)
order_by q25 129.88 133.07 -3.19 (-2.40%)
order_by q26 454.50 474.13 -19.63 (-4.14%)
order_by q27 1410.33 1393.96 16.37 (1.17%)
recursive_join recursive-join-bidirection 293.69 299.19 -5.50 (-1.84%)
recursive_join recursive-join-dense 7386.50 7360.69 25.81 (0.35%)
recursive_join recursive-join-path 24332.00 24157.18 174.82 (0.72%)
recursive_join recursive-join-sparse 1053.41 1063.70 -10.29 (-0.97%)
recursive_join recursive-join-trail 7336.51 7359.31 -22.80 (-0.31%)
scan_after_filter q01 171.43 175.18 -3.76 (-2.14%)
scan_after_filter q02 157.48 159.04 -1.56 (-0.98%)
shortest_path_ldbc100 q37 82.49 85.66 -3.18 (-3.71%)
shortest_path_ldbc100 q38 384.74 355.90 28.84 (8.10%)
shortest_path_ldbc100 q39 66.73 58.66 8.06 (13.75%)
shortest_path_ldbc100 q40 403.01 472.53 -69.51 (-14.71%)
var_size_expr_evaluator q03 2120.67 2075.79 44.87 (2.16%)
var_size_expr_evaluator q04 2247.82 2237.75 10.07 (0.45%)
var_size_expr_evaluator q05 2953.00 2627.43 325.57 (12.39%)
var_size_expr_evaluator q06 1330.08 1342.04 -11.96 (-0.89%)
var_size_seq_scan q19 1483.90 1481.24 2.66 (0.18%)
var_size_seq_scan q20 2382.87 2332.86 50.01 (2.14%)
var_size_seq_scan q21 2342.16 2274.02 68.14 (3.00%)
var_size_seq_scan q22 128.48 128.18 0.31 (0.24%)

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.48%. Comparing base (b3e085f) to head (669570e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/function/gds/all_shortest_paths.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4896      +/-   ##
==========================================
- Coverage   86.53%   86.48%   -0.05%     
==========================================
  Files        1403     1403              
  Lines       60529    60466      -63     
  Branches     7435     7430       -5     
==========================================
- Hits        52379    52297      -82     
- Misses       7981     8000      +19     
  Partials      169      169              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit 5399489 into master Feb 13, 2025
25 checks passed
@andyfengHKU andyfengHKU deleted the remove-recursive-extend-binding branch February 13, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants