Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean update info during node group checkpoint #4895

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Feb 13, 2025

Description

Fix the clearing of versioned update info chain during checkpointing. This fixed the problem of accumulated updates leading to OOM due to that the update info are not cleared during checkpoint.

Copy link

Benchmark Result

Master commit hash: b3e085f6e9914cdd8a35effd2750751616c997fa
Branch commit hash: 2efbe595b4786036e4ed0c2254e338d8bd8e5f56

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 723.02 724.58 -1.56 (-0.22%)
aggregation q28 6438.14 6338.05 100.09 (1.58%)
filter q14 120.80 127.55 -6.75 (-5.29%)
filter q15 127.91 124.44 3.47 (2.79%)
filter q16 291.31 306.33 -15.02 (-4.90%)
filter q17 441.05 471.91 -30.86 (-6.54%)
filter q18 1949.51 1969.97 -20.46 (-1.04%)
filter zonemap-node 82.55 90.10 -7.55 (-8.38%)
filter zonemap-node-lhs-cast 81.02 88.50 -7.48 (-8.45%)
filter zonemap-node-null 80.96 88.34 -7.38 (-8.35%)
filter zonemap-rel 5370.32 5406.63 -36.31 (-0.67%)
fixed_size_expr_evaluator q07 571.01 578.16 -7.15 (-1.24%)
fixed_size_expr_evaluator q08 824.19 810.95 13.25 (1.63%)
fixed_size_expr_evaluator q09 820.91 808.24 12.67 (1.57%)
fixed_size_expr_evaluator q10 241.05 243.90 -2.85 (-1.17%)
fixed_size_expr_evaluator q11 234.75 237.42 -2.67 (-1.13%)
fixed_size_expr_evaluator q12 230.72 233.81 -3.09 (-1.32%)
fixed_size_expr_evaluator q13 1477.89 1452.11 25.78 (1.78%)
fixed_size_seq_scan q23 109.37 120.82 -11.46 (-9.48%)
join q29 721.09 790.78 -69.69 (-8.81%)
join q30 10946.96 10771.95 175.01 (1.62%)
join q31 7.60 5.42 2.18 (40.15%)
join SelectiveTwoHopJoin 57.35 54.98 2.38 (4.32%)
ldbc_snb_ic q35 2596.21 2599.88 -3.67 (-0.14%)
ldbc_snb_ic q36 462.18 460.25 1.92 (0.42%)
ldbc_snb_is q32 4.73 4.95 -0.23 (-4.55%)
ldbc_snb_is q33 14.20 16.52 -2.32 (-14.03%)
ldbc_snb_is q34 1.24 1.24 0.00 (0.16%)
multi-rel multi-rel-large-scan 1404.09 1312.56 91.54 (6.97%)
multi-rel multi-rel-lookup 45.99 18.22 27.78 (152.49%)
multi-rel multi-rel-small-scan 84.84 87.17 -2.33 (-2.67%)
order_by q25 138.81 133.07 5.74 (4.31%)
order_by q26 460.65 474.13 -13.48 (-2.84%)
order_by q27 1429.72 1393.96 35.76 (2.57%)
recursive_join recursive-join-bidirection 287.73 299.19 -11.47 (-3.83%)
recursive_join recursive-join-dense 7373.39 7360.69 12.70 (0.17%)
recursive_join recursive-join-path 24177.29 24157.18 20.11 (0.08%)
recursive_join recursive-join-sparse 1063.12 1063.70 -0.58 (-0.05%)
recursive_join recursive-join-trail 7340.65 7359.31 -18.66 (-0.25%)
scan_after_filter q01 170.13 175.18 -5.06 (-2.89%)
scan_after_filter q02 157.32 159.04 -1.72 (-1.08%)
shortest_path_ldbc100 q37 91.29 85.66 5.63 (6.57%)
shortest_path_ldbc100 q38 377.01 355.90 21.11 (5.93%)
shortest_path_ldbc100 q39 61.97 58.66 3.30 (5.63%)
shortest_path_ldbc100 q40 462.64 472.53 -9.88 (-2.09%)
var_size_expr_evaluator q03 2081.11 2075.79 5.32 (0.26%)
var_size_expr_evaluator q04 2243.30 2237.75 5.55 (0.25%)
var_size_expr_evaluator q05 2618.52 2627.43 -8.91 (-0.34%)
var_size_expr_evaluator q06 1319.81 1342.04 -22.23 (-1.66%)
var_size_seq_scan q19 1450.64 1481.24 -30.61 (-2.07%)
var_size_seq_scan q20 2327.16 2332.86 -5.70 (-0.24%)
var_size_seq_scan q21 2257.18 2274.02 -16.84 (-0.74%)
var_size_seq_scan q22 127.54 128.18 -0.63 (-0.49%)

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.53%. Comparing base (4ddee1b) to head (c362e16).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4895      +/-   ##
==========================================
- Coverage   86.53%   86.53%   -0.01%     
==========================================
  Files        1403     1403              
  Lines       60545    60530      -15     
  Branches     7442     7435       -7     
==========================================
- Hits        52395    52377      -18     
- Misses       7981     7984       +3     
  Partials      169      169              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 marked this pull request as ready for review February 14, 2025 14:21
@ray6080 ray6080 removed the request for review from benjaminwinger February 14, 2025 14:22
@ray6080 ray6080 merged commit 46f2f37 into master Feb 14, 2025
@ray6080 ray6080 deleted the clear-update-info branch February 14, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants