-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes the alias
issue of struct_pack
function
#4894
Conversation
alias
issue of struct_pack
functionalias
issue of struct_pack
function
Benchmark ResultMaster commit hash:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4894 +/- ##
=======================================
Coverage 86.52% 86.53%
=======================================
Files 1403 1403
Lines 60519 60529 +10
Branches 7433 7435 +2
=======================================
+ Hits 52364 52376 +12
+ Misses 7986 7983 -3
- Partials 169 170 +1 ☔ View full report in Codecov by Sentry. |
Benchmark ResultMaster commit hash:
|
We used to set the
alias
ofstruct-pack
function parameters as their field names.E.g.
{'x': y}
=> We set the alias ofy
as xThis causes a bug in nested aggregation:
This PR fixes it by introducing the optionalParams field in the functionExpression